Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: ipc/ipc_channel.h

Issue 25325002: workaround for mac kernel bug (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: test now actually triggers kernel bug, auto-flush CloseFD messages Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_channel.h
diff --git a/ipc/ipc_channel.h b/ipc/ipc_channel.h
index f65a62b9cc9ee4fda212d66b513f76c60737ba9c..f9e3532672e861f6f594cb8b404765fd2d2739cd 100644
--- a/ipc/ipc_channel.h
+++ b/ipc/ipc_channel.h
@@ -80,10 +80,14 @@ class IPC_EXPORT Channel : public Sender {
// just the process id (pid). The message has a special routing_id
// (MSG_ROUTING_NONE) and type (HELLO_MESSAGE_TYPE).
enum {
- HELLO_MESSAGE_TYPE = kuint16max // Maximum value of message type (uint16),
+ HELLO_MESSAGE_TYPE = kuint16max, // Maximum value of message type (uint16),
// to avoid conflicting with normal
// message types, which are enumeration
// constants starting from 0.
+
+ // The CLOSE_FD_MESSAGE_TYPE is used internall in the IPC class to
+ // work around a bug in sendmsg() on Mac.
+ CLOSE_FD_MESSAGE_TYPE = kuint16max - 1
Scott Hess - ex-Googler 2013/10/09 20:18:33 internall -> internally. I think the comment is s
hubbe 2013/10/09 21:34:12 Done.
};
// The maximum message size in bytes. Attempting to receive a message of this

Powered by Google App Engine
This is Rietveld 408576698