tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py - Issue 2532483003: Replace the term 'poor man' with another phrase (gender-neutral fixit).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py

Issue 2532483003: Replace the term 'poor man' with another phrase (gender-neutral fixit). (Closed)

Patch Set: Fix grammar. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/js/mozilla/resources/mozilla-es5-shell.js ('K') | « third_party/WebKit/Source/core/frame/SmartClip.h ('k') | ui/gfx/x/x11_error_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py

diff --git a/tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py b/tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py

index 5917fb447ea5df569b1dc6c62537bcff79798f79..12d1a917717dfc8fc8b905cfdab4bf4cc88fa27c 100755

--- a/tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py

+++ b/tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py

@@ -67,8 +67,8 @@ class XMLFormattedWriter(template_writer.TemplateWriter):

# This is problematic both for the OSX Workgroup Manager (plist files) and

# the Windows Group Policy Editor (admx files). What they need instead:

# <string>value of string</string>

- # So we use the poor man's pretty printer here. It assumes that there are

- # no mixed-content nodes.

+ # So we use a different printer here. It assumes that there are no

Nico 2016/11/29 16:17:07 This doesn't mean the same thing. From what I can

Matt Giuca 2016/11/30 07:28:59 Done.

+ # mixed-content nodes.

# Get all the XML content in a one-line string.

xml = doc.toxml(**kwargs)

# Determine where the line breaks will be. (They will only be between tags.)