Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: remoting/host/linux/x11_util.cc

Issue 2532483003: Replace the term 'poor man' with another phrase (gender-neutral fixit). (Closed)
Patch Set: Fix grammar. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/linux/x11_util.cc
diff --git a/remoting/host/linux/x11_util.cc b/remoting/host/linux/x11_util.cc
index 1e88ba78c5fbdbea6ea8dfab6fabe56bb239a495..cda4058bfb768cb22e5631a1debfe345944a3c1a 100644
--- a/remoting/host/linux/x11_util.cc
+++ b/remoting/host/linux/x11_util.cc
@@ -15,10 +15,10 @@ static ScopedXErrorHandler* g_handler = nullptr;
ScopedXErrorHandler::ScopedXErrorHandler(const Handler& handler):
handler_(handler),
ok_(true) {
- // This is a poor-man's check for incorrect usage. It doesn't handle the case
- // where a mix of ScopedXErrorHandler and raw XSetErrorHandler calls are used,
- // and it disallows nested ScopedXErrorHandlers on the same thread, despite
- // these being perfectly safe.
+ // This is an non-exhaustive check for incorrect usage. It doesn't handle the
Lambros 2016/11/29 18:36:06 s/an/a/
Matt Giuca 2016/11/30 07:28:59 Done.
+ // case where a mix of ScopedXErrorHandler and raw XSetErrorHandler calls are
+ // used, and it disallows nested ScopedXErrorHandlers on the same thread,
+ // despite these being perfectly safe.
DCHECK(g_handler == nullptr);
g_handler = this;
previous_handler_ = XSetErrorHandler(HandleXErrors);

Powered by Google App Engine
This is Rietveld 408576698