Replace the term 'poor man' with another phrase (gender-neutral fixit).

Replace the term 'poor man' with another phrase (gender-neutral fixit).

BUG=542537
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Committed: https://crrev.com/6c27f666078aab16c7e884c1ff7eeb166ebfb8ea
Cr-Commit-Position: refs/heads/master@{#436211}

[Matt Giuca, 2016-11-25 00:19:00]

Description was changed from

==========
Replace the term 'poor man' with another phrase (gender-neutral fixit).

BUG=542537
==========

to

==========
Replace the term 'poor man' with another phrase (gender-neutral fixit).

BUG=542537
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[Matt Giuca, 2016-11-29 06:45:43]

mgiuca@chromium.org changed reviewers:
+ davidben@chromium.org, garykac@chromium.org, jschuh@chromium.org,
raymes@chromium.org, sehr@chromium.org, thakis@chromium.org

[Matt Giuca, 2016-11-29 06:45:43]

Reviewers, please look at the following files (all minor changes):

davidben:
  crypto/p224_spake_unittest.cc
garykac:
  remoting/host/linux/x11_util.cc
jschuh:
  sandbox/win/src/internal_types.h
raymes:
  ppapi/examples/*
sehr:
  components/nacl/*
  native_client_sdk/src/examples/*
thakis:
  third_party/WebKit/*
  tools/grit/*
  ui/gfx/x/x11_error_tracker.cc

Thanks!

Note: There's been some discussion about the term "poor man" and whether it's a
problem for gender neutrality. The conclusion was that it is unnecessary to keep
this term, and "poor person" shares some other problems (non-native English
speakers may not understand as it is slang, and it's also a classist term.) So
just replacing it with functionally equivalent terms, or removing it altogether
if it didn't add any information.

https://codereview.chromium.org/2532483003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/js/mozilla/resources/mozilla-es5-shell.js
(right):

https://codereview.chromium.org/2532483003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/js/mozilla/resources/mozilla-es5-shell.js:97:
* of whitespace with a single horizontal space (simple tokenization).
Note: Not sure if we're supposed to change these or if they're like third-party
code.

But I see a few changes to the code after it was imported so I figure we can
change it.

[davidben, 2016-11-29 14:54:55]

crypto lgtm

[jschuh, 2016-11-29 15:41:50]

sandbox lgtm

[Nico, 2016-11-29 16:17:07]

lgtm

https://codereview.chromium.org/2532483003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/js/mozilla/resources/mozilla-es5-shell.js
(right):

https://codereview.chromium.org/2532483003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/js/mozilla/resources/mozilla-es5-shell.js:97:
* of whitespace with a single horizontal space (simple tokenization).
On 2016/11/29 06:45:43, Matt Giuca wrote:
> Note: Not sure if we're supposed to change these or if they're like
third-party
> code.
> 
> But I see a few changes to the code after it was imported so I figure we can
> change it.

I don't know either, but I assume it's fine for the reason you mention.

https://codereview.chromium.org/2532483003/diff/40001/tools/grit/grit/format/...
File tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py
(right):

https://codereview.chromium.org/2532483003/diff/40001/tools/grit/grit/format/...
tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py:70: # So
we use a different printer here. It assumes that there are no
This doesn't mean the same thing. From what I can tell, the code does hacky
pretty-printing by splitting the xml on ><. Maybe s/different/hacked-up/?

[binji, 2016-11-29 18:07:16]

native_client_sdk lgtm

[Lambros, 2016-11-29 18:36:06]

lambroslambrou@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Lambros, 2016-11-29 18:36:06]

lgtm for remoting/

https://codereview.chromium.org/2532483003/diff/40001/remoting/host/linux/x11...
File remoting/host/linux/x11_util.cc (right):

https://codereview.chromium.org/2532483003/diff/40001/remoting/host/linux/x11...
remoting/host/linux/x11_util.cc:18: // This is an non-exhaustive check for
incorrect usage. It doesn't handle the
s/an/a/

[raymes, 2016-11-29 23:11:29]

lgtm

https://codereview.chromium.org/2532483003/diff/40001/ppapi/examples/composit...
File ppapi/examples/compositor/compositor.cc (right):

https://codereview.chromium.org/2532483003/diff/40001/ppapi/examples/composit...
ppapi/examples/compositor/compositor.cc:32: // Use assert as a CHECK, even in
non-debug mode.
poor-man's -> makeshift (and elsewhere)

[Matt Giuca, 2016-11-30 07:28:59]

https://codereview.chromium.org/2532483003/diff/40001/ppapi/examples/composit...
File ppapi/examples/compositor/compositor.cc (right):

https://codereview.chromium.org/2532483003/diff/40001/ppapi/examples/composit...
ppapi/examples/compositor/compositor.cc:32: // Use assert as a CHECK, even in
non-debug mode.
On 2016/11/29 23:11:29, raymes wrote:
> poor-man's -> makeshift (and elsewhere)

Done.

https://codereview.chromium.org/2532483003/diff/40001/remoting/host/linux/x11...
File remoting/host/linux/x11_util.cc (right):

https://codereview.chromium.org/2532483003/diff/40001/remoting/host/linux/x11...
remoting/host/linux/x11_util.cc:18: // This is an non-exhaustive check for
incorrect usage. It doesn't handle the
On 2016/11/29 18:36:06, Lambros wrote:
> s/an/a/

Done.

https://codereview.chromium.org/2532483003/diff/40001/tools/grit/grit/format/...
File tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py
(right):

https://codereview.chromium.org/2532483003/diff/40001/tools/grit/grit/format/...
tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py:70: # So
we use a different printer here. It assumes that there are no
On 2016/11/29 16:17:07, Nico wrote:
> This doesn't mean the same thing. From what I can tell, the code does hacky
> pretty-printing by splitting the xml on ><. Maybe s/different/hacked-up/?

Done.

[Matt Giuca, 2016-11-30 22:36:55]

On 2016/11/30 07:28:59, Matt Giuca wrote:
>
https://codereview.chromium.org/2532483003/diff/40001/ppapi/examples/composit...
> File ppapi/examples/compositor/compositor.cc (right):
> 
>
https://codereview.chromium.org/2532483003/diff/40001/ppapi/examples/composit...
> ppapi/examples/compositor/compositor.cc:32: // Use assert as a CHECK, even in
> non-debug mode.
> On 2016/11/29 23:11:29, raymes wrote:
> > poor-man's -> makeshift (and elsewhere)
> 
> Done.
> 
>
https://codereview.chromium.org/2532483003/diff/40001/remoting/host/linux/x11...
> File remoting/host/linux/x11_util.cc (right):
> 
>
https://codereview.chromium.org/2532483003/diff/40001/remoting/host/linux/x11...
> remoting/host/linux/x11_util.cc:18: // This is an non-exhaustive check for
> incorrect usage. It doesn't handle the
> On 2016/11/29 18:36:06, Lambros wrote:
> > s/an/a/
> 
> Done.
> 
>
https://codereview.chromium.org/2532483003/diff/40001/tools/grit/grit/format/...
> File tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py
> (right):
> 
>
https://codereview.chromium.org/2532483003/diff/40001/tools/grit/grit/format/...
> tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py:70: #
So
> we use a different printer here. It assumes that there are no
> On 2016/11/29 16:17:07, Nico wrote:
> > This doesn't mean the same thing. From what I can tell, the code does hacky
> > pretty-printing by splitting the xml on ><. Maybe s/different/hacked-up/?
> 
> Done.

sehr, garykac: friendly ping

garykac:
  remoting/host/linux/x11_util.cc
sehr:
  components/nacl/*
  native_client_sdk/src/examples/*

Thanks!

[binji, 2016-12-01 20:39:30]

Description was changed from

==========
Replace the term 'poor man' with another phrase (gender-neutral fixit).

BUG=542537
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Replace the term 'poor man' with another phrase (gender-neutral fixit).

BUG=542537
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[binji, 2016-12-01 20:39:30]

binji@chromium.org changed reviewers:
+ dschuff@chromium.org

[binji, 2016-12-01 20:39:42]

On 2016/11/30 22:36:55, Matt Giuca wrote:
> On 2016/11/30 07:28:59, Matt Giuca wrote:
> >
>
https://codereview.chromium.org/2532483003/diff/40001/ppapi/examples/composit...
> > File ppapi/examples/compositor/compositor.cc (right):
> > 
> >
>
https://codereview.chromium.org/2532483003/diff/40001/ppapi/examples/composit...
> > ppapi/examples/compositor/compositor.cc:32: // Use assert as a CHECK, even
in
> > non-debug mode.
> > On 2016/11/29 23:11:29, raymes wrote:
> > > poor-man's -> makeshift (and elsewhere)
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/2532483003/diff/40001/remoting/host/linux/x11...
> > File remoting/host/linux/x11_util.cc (right):
> > 
> >
>
https://codereview.chromium.org/2532483003/diff/40001/remoting/host/linux/x11...
> > remoting/host/linux/x11_util.cc:18: // This is an non-exhaustive check for
> > incorrect usage. It doesn't handle the
> > On 2016/11/29 18:36:06, Lambros wrote:
> > > s/an/a/
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/2532483003/diff/40001/tools/grit/grit/format/...
> > File tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py
> > (right):
> > 
> >
>
https://codereview.chromium.org/2532483003/diff/40001/tools/grit/grit/format/...
> > tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py:70:
#
> So
> > we use a different printer here. It assumes that there are no
> > On 2016/11/29 16:17:07, Nico wrote:
> > > This doesn't mean the same thing. From what I can tell, the code does
hacky
> > > pretty-printing by splitting the xml on ><. Maybe s/different/hacked-up/?
> > 
> > Done.
> 
> sehr, garykac: friendly ping
> 
> garykac:
>   remoting/host/linux/x11_util.cc
> sehr:
>   components/nacl/*
>   native_client_sdk/src/examples/*
> 
> Thanks!

+dschuff

sehr's not on the team anymore. I've reviewed native_client_sdk, and dschuff can
review components/nacl.

[Matt Giuca, 2016-12-02 07:03:19]

On 2016/12/01 20:39:42, binji wrote:
> On 2016/11/30 22:36:55, Matt Giuca wrote:
> > On 2016/11/30 07:28:59, Matt Giuca wrote:
> > >
> >
>
https://codereview.chromium.org/2532483003/diff/40001/ppapi/examples/composit...
> > > File ppapi/examples/compositor/compositor.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2532483003/diff/40001/ppapi/examples/composit...
> > > ppapi/examples/compositor/compositor.cc:32: // Use assert as a CHECK, even
> in
> > > non-debug mode.
> > > On 2016/11/29 23:11:29, raymes wrote:
> > > > poor-man's -> makeshift (and elsewhere)
> > > 
> > > Done.
> > > 
> > >
> >
>
https://codereview.chromium.org/2532483003/diff/40001/remoting/host/linux/x11...
> > > File remoting/host/linux/x11_util.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2532483003/diff/40001/remoting/host/linux/x11...
> > > remoting/host/linux/x11_util.cc:18: // This is an non-exhaustive check for
> > > incorrect usage. It doesn't handle the
> > > On 2016/11/29 18:36:06, Lambros wrote:
> > > > s/an/a/
> > > 
> > > Done.
> > > 
> > >
> >
>
https://codereview.chromium.org/2532483003/diff/40001/tools/grit/grit/format/...
> > > File
tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py
> > > (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2532483003/diff/40001/tools/grit/grit/format/...
> > >
tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py:70:
> #
> > So
> > > we use a different printer here. It assumes that there are no
> > > On 2016/11/29 16:17:07, Nico wrote:
> > > > This doesn't mean the same thing. From what I can tell, the code does
> hacky
> > > > pretty-printing by splitting the xml on ><. Maybe
s/different/hacked-up/?
> > > 
> > > Done.
> > 
> > sehr, garykac: friendly ping
> > 
> > garykac:
> >   remoting/host/linux/x11_util.cc
> > sehr:
> >   components/nacl/*
> >   native_client_sdk/src/examples/*
> > 
> > Thanks!
> 
> +dschuff
> 
> sehr's not on the team anymore. I've reviewed native_client_sdk, and dschuff
can
> review components/nacl.

Thanks for arranging that.

[Derek Schuff, 2016-12-02 18:11:35]

components/nacl LGTM

[Matt Giuca, 2016-12-04 23:25:18]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-12-04 23:25:18]

The patchset sent to the CQ was uploaded after l-g-t-m from jschuh@chromium.org,
davidben@chromium.org, lambroslambrou@chromium.org, raymes@chromium.org,
thakis@chromium.org, binji@chromium.org
Link to the patchset: https://codereview.chromium.org/2532483003/#ps60001
(title: "Respond to review comments.")

[commit-bot: I haz the power, 2016-12-04 23:25:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 01:42:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480893918518450,
"parent_rev": "49634cc59c64e4ff032ad8ccd1e0d06f56c9e5f7", "commit_rev":
"a59dda6ccfdee055fa21faae950cf7fea2ac035b"}

[commit-bot: I haz the power, 2016-12-05 01:42:31]

Description was changed from

==========
Replace the term 'poor man' with another phrase (gender-neutral fixit).

BUG=542537
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Replace the term 'poor man' with another phrase (gender-neutral fixit).

BUG=542537
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[commit-bot: I haz the power, 2016-12-05 01:42:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-05 01:46:59]

Description was changed from

==========
Replace the term 'poor man' with another phrase (gender-neutral fixit).

BUG=542537
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Replace the term 'poor man' with another phrase (gender-neutral fixit).

BUG=542537
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Committed: https://crrev.com/6c27f666078aab16c7e884c1ff7eeb166ebfb8ea
Cr-Commit-Position: refs/heads/master@{#436211}
==========

[commit-bot: I haz the power, 2016-12-05 01:47:01]

Patchset 4 (id:??) landed as
https://crrev.com/6c27f666078aab16c7e884c1ff7eeb166ebfb8ea
Cr-Commit-Position: refs/heads/master@{#436211}