Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2532463002: [turbofan] Assign types to remaining builtins on String.prototype. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Assign types to remaining builtins on String.prototype. Assign types to the remaining builtins on the String.prototype where we know a meaningful type, i.e. where the type is not dependent on some callable function that is pass or loaded. BUG=v8:5267 R=yangguo@chromium.org Committed: https://crrev.com/ae14b6b72102ea5b39dee9d115aedd0efad675d1 Cr-Commit-Position: refs/heads/master@{#41294}

Patch Set 1 #

Patch Set 2 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M src/compiler/typer.cc View 1 2 chunks +26 lines, -0 lines 0 comments Download
M src/objects.h View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Benedikt Meurer
4 years ago (2016-11-24 13:27:03 UTC) #1
Yang
nice. lgtm. thanks.
4 years ago (2016-11-24 13:28:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532463002/1
4 years ago (2016-11-24 13:34:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/8585) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years ago (2016-11-24 14:04:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532463002/20001
4 years ago (2016-11-27 18:51:26 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-27 19:20:28 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-27 19:20:48 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae14b6b72102ea5b39dee9d115aedd0efad675d1
Cr-Commit-Position: refs/heads/master@{#41294}

Powered by Google App Engine
This is Rietveld 408576698