Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: src/inspector/wasm-translation.cc

Issue 2532433003: [inspector] Split V8DebuggerScript implementation for wasm (Closed)
Patch Set: Refactor a bit Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/wasm-translation.cc
diff --git a/src/inspector/wasm-translation.cc b/src/inspector/wasm-translation.cc
index 0775460ae715f9b3bcfabcf539a0f7e77fa3938e..693b374813aac5d2af020531650ab428c2813ecd 100644
--- a/src/inspector/wasm-translation.cc
+++ b/src/inspector/wasm-translation.cc
@@ -183,11 +183,15 @@ class WasmTranslation::TranslatorImpl::DisassemblingTranslator
String16 fake_script_id = GetFakeScriptId(loc);
String16 fake_script_url = GetFakeScriptUrl(loc);
String16 source(disassembly.first.data(), disassembly.first.length());
- std::unique_ptr<V8DebuggerScript> fake_script(new V8DebuggerScript(
- fake_script_id, std::move(fake_script_url), source));
- loc->translation->AddFakeScript(std::move(fake_script), this,
- loc->context_group_id);
+ Local<DebugInterface::Script> script_wrapper =
+ DebugInterface::Script::Wrap(isolate, script_.Get(isolate))
+ .ToLocalChecked();
+ loc->translation->AddFakeScript(
+ V8DebuggerScript::CreateWasm(script_wrapper, std::move(fake_script_id),
+ std::move(fake_script_url),
+ std::move(source)),
+ this, loc->context_group_id);
return it->second;
}

Powered by Google App Engine
This is Rietveld 408576698