Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: src/inspector/v8-debugger.cc

Issue 2532433003: [inspector] Split V8DebuggerScript implementation for wasm (Closed)
Patch Set: Minor refactoring Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/v8-debugger-script.h » ('j') | src/inspector/v8-debugger-script.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger.cc
diff --git a/src/inspector/v8-debugger.cc b/src/inspector/v8-debugger.cc
index 6ebd55798f4bd48bd540b18efe82dac39fad7843..cf2f2ea311d0dfef2973d8dbe99468ad0e8c2673 100644
--- a/src/inspector/v8-debugger.cc
+++ b/src/inspector/v8-debugger.cc
@@ -130,8 +130,7 @@ void V8Debugger::getCompiledScripts(
if (!script->ContextData().ToLocal(&v8ContextData)) continue;
String16 contextData = toProtocolString(v8ContextData);
if (contextData.find(contextPrefix) != 0) continue;
- result.push_back(std::unique_ptr<V8DebuggerScript>(
- new V8DebuggerScript(m_isolate, script, false)));
+ result.push_back(V8DebuggerScript::Create(m_isolate, script, false));
}
}
@@ -596,8 +595,7 @@ void V8Debugger::handleV8DebugEvent(
m_wasmTranslation.AddScript(scriptWrapper.As<v8::Object>());
} else if (m_ignoreScriptParsedEventsCounter == 0) {
agent->didParseSource(
- std::unique_ptr<V8DebuggerScript>(
- new V8DebuggerScript(m_isolate, script, inLiveEditScope)),
+ V8DebuggerScript::Create(m_isolate, script, inLiveEditScope),
event == v8::AfterCompile);
}
} else if (event == v8::Exception) {
« no previous file with comments | « no previous file | src/inspector/v8-debugger-script.h » ('j') | src/inspector/v8-debugger-script.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698