Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: chrome/browser/search_engines/template_url.h

Issue 25324003: search: Log when bookmark bar is pinned. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url.h
diff --git a/chrome/browser/search_engines/template_url.h b/chrome/browser/search_engines/template_url.h
index 1798e1a6c78ee5e1026d2a7db2b4fb22ec6247e3..ded40f6a0e8fb2d5fab29135fa8effe4c72e7d80 100644
--- a/chrome/browser/search_engines/template_url.h
+++ b/chrome/browser/search_engines/template_url.h
@@ -101,6 +101,9 @@ class TemplateURLRef {
// Which omnibox the user used to type the prefix.
AutocompleteInput::PageClassification page_classification;
+ // True for searches issued with the bookmark bar pref set to shown.
+ bool bookmark_bar_pinned;
+
// If set, ReplaceSearchTerms() will automatically append any extra query
// params specified via the --extra-search-query-params command-line
// argument. Generally, this should be set when dealing with the search or
@@ -231,6 +234,7 @@ class TemplateURLRef {
FRIEND_TEST_ALL_PREFIXES(TemplateURLTest, ParseURLTwoParameters);
FRIEND_TEST_ALL_PREFIXES(TemplateURLTest, ParseURLNestedParameter);
FRIEND_TEST_ALL_PREFIXES(TemplateURLTest, URLRefTestImageURLWithPOST);
+ FRIEND_TEST_ALL_PREFIXES(TemplateURLTest, ReflectsBookmarkBarPinned);
// Enumeration of the known types.
enum ReplacementType {
@@ -238,6 +242,7 @@ class TemplateURLRef {
GOOGLE_ASSISTED_QUERY_STATS,
GOOGLE_BASE_URL,
GOOGLE_BASE_SUGGEST_URL,
+ GOOGLE_BOOKMARK_BAR_PINNED,
GOOGLE_CURSOR_POSITION,
GOOGLE_IMAGE_ORIGINAL_HEIGHT,
GOOGLE_IMAGE_ORIGINAL_WIDTH,
@@ -384,6 +389,9 @@ class TemplateURLRef {
// Whether the contained URL is a pre-populated URL.
bool prepopulated_;
+ // Whether search terms are shown in the omnibox on search results pages.
Peter Kasting 2013/10/01 21:54:55 Nit: Maybe add "This is kept as a member so it can
Jered 2013/10/01 23:07:07 Done.
+ bool showing_search_terms_;
+
DISALLOW_COPY_AND_ASSIGN(TemplateURLRef);
};
@@ -680,6 +688,7 @@ class TemplateURL {
private:
friend class TemplateURLService;
+ FRIEND_TEST_ALL_PREFIXES(TemplateURLTest, ReflectsBookmarkBarPinned);
void CopyFrom(const TemplateURL& other);

Powered by Google App Engine
This is Rietveld 408576698