Make redo command to correct selection in undo stack

Make redo command to correct selection in undo stack

This patch makes |Editor::reappliedEditing()|, which is the last step of "redo"
command, to use |correctVisibleSelection()| to validate selection in undo stack
like |Editor::unappliedEditing()|, which is the last step of "undo" command.

The root cause of issue 669127 is "redo" command attempt to set selection
anchored with SELECT element in OPTION element out of SELECT element. Since this
SELECT element isn't appeared in flat tree,
|SelectionAdjuster::adjustSelectionInFlatTree()| is failed with |nullptr| of
parent of that.

BUG=669127
TEST=LayoutTests/editing/undo/redo_correct_selection.html

Committed: https://crrev.com/c5d325233d9e3e7b35aa65ee4a6b78261fb9c94c
Cr-Commit-Position: refs/heads/master@{#435191}

[yosin_UTC9, 2016-11-29 07:58:20]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 07:58:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-11-29 09:24:03]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 09:24:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-11-29 09:27:41]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 09:27:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-11-29 09:43:41]

Description was changed from

==========
2016-11-29T16:56:30

BUG=
==========

to

==========
Make redo command to correct selection in undo stack

This patch makes |Editor::reappliedEditing()|, which is the last step of "redo"
command, to use |correctVisibleSelection()| to validate selection in undo stack
like |Editor::unappliedEditing()|, which is the last step of "undo" command.

The root cause of issue 669127 is "redo" command attempt to set selection
anchored with SELECT element in OPTION element out of SELECT element. Since this
SELECT element isn't appeared in flat tree,
|SelectionAdjuster::adjustSelectionInFlatTree()| is failed with |nullptr| of
parent of that.


BUG=669127
TEST=LayoutTests/editing/undo/redo_correct_selection.html
==========

[yosin_UTC9, 2016-11-29 09:43:53]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-11-29 09:43:54]

PTAL

[commit-bot: I haz the power, 2016-11-29 10:56:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 10:56:40]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-11-29 11:50:44]

https://codereview.chromium.org/2532393002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/undo/redo_correct_selection.html
(right):

https://codereview.chromium.org/2532393002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/undo/redo_correct_selection.html:18:
console.log(currentCommand);
This shouldn't be in a layout test.

https://codereview.chromium.org/2532393002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/undo/redo_correct_selection.html:25:
console.log(div.outerHTML);
ditto.

[yosin_UTC9, 2016-11-30 02:29:18]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 02:30:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-11-30 02:30:19]

PTAL

https://codereview.chromium.org/2532393002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/undo/redo_correct_selection.html
(right):

https://codereview.chromium.org/2532393002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/undo/redo_correct_selection.html:18:
console.log(currentCommand);
On 2016/11/29 at 11:50:44, Xiaocheng wrote:
> This shouldn't be in a layout test.

Done. Oops.

https://codereview.chromium.org/2532393002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/undo/redo_correct_selection.html:25:
console.log(div.outerHTML);
On 2016/11/29 at 11:50:44, Xiaocheng wrote:
> ditto.

Done. Oops.

[Xiaocheng, 2016-11-30 02:31:37]

lgtm

[yosin_UTC9, 2016-11-30 03:19:04]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2016-11-30 03:19:06]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-11-30 03:19:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 04:32:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 04:32:41]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[yosin_UTC9, 2016-11-30 04:33:40]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-11-30 04:34:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 05:20:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 05:20:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[yosin_UTC9, 2016-11-30 07:51:56]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-11-30 07:53:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 09:07:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480492316032980,
"parent_rev": "d47e1fbda552648bfa9dc7589eb98dc1bd37a00b", "commit_rev":
"a271477541441ac0f6eaec8fa85eacefce7593f0"}

[commit-bot: I haz the power, 2016-11-30 09:07:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-30 09:10:32]

Description was changed from

==========
Make redo command to correct selection in undo stack

This patch makes |Editor::reappliedEditing()|, which is the last step of "redo"
command, to use |correctVisibleSelection()| to validate selection in undo stack
like |Editor::unappliedEditing()|, which is the last step of "undo" command.

The root cause of issue 669127 is "redo" command attempt to set selection
anchored with SELECT element in OPTION element out of SELECT element. Since this
SELECT element isn't appeared in flat tree,
|SelectionAdjuster::adjustSelectionInFlatTree()| is failed with |nullptr| of
parent of that.


BUG=669127
TEST=LayoutTests/editing/undo/redo_correct_selection.html
==========

to

==========
Make redo command to correct selection in undo stack

This patch makes |Editor::reappliedEditing()|, which is the last step of "redo"
command, to use |correctVisibleSelection()| to validate selection in undo stack
like |Editor::unappliedEditing()|, which is the last step of "undo" command.

The root cause of issue 669127 is "redo" command attempt to set selection
anchored with SELECT element in OPTION element out of SELECT element. Since this
SELECT element isn't appeared in flat tree,
|SelectionAdjuster::adjustSelectionInFlatTree()| is failed with |nullptr| of
parent of that.

BUG=669127
TEST=LayoutTests/editing/undo/redo_correct_selection.html

Committed: https://crrev.com/c5d325233d9e3e7b35aa65ee4a6b78261fb9c94c
Cr-Commit-Position: refs/heads/master@{#435191}
==========

[commit-bot: I haz the power, 2016-11-30 09:10:34]

Patchset 3 (id:??) landed as
https://crrev.com/c5d325233d9e3e7b35aa65ee4a6b78261fb9c94c
Cr-Commit-Position: refs/heads/master@{#435191}