third_party/WebKit/LayoutTests/editing/execCommand/format-block-contenteditable-false-expected.txt - Issue 2532373002: (CANCELED) Ensure before/after is within the editable in moveParagraphWithClones

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/execCommand/format-block-contenteditable-false-expected.txt

Issue 2532373002: (CANCELED) Ensure before/after is within the editable in moveParagraphWithClones (Closed)

Patch Set: Rebaseline Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 formatblock on selection with a contenteditable="false" child.	1 formatblock on selection with a contenteditable="false" child.

2 \| <h1>	2 \| <h1>
	yosin_UTC9 2016/11/30 01:48:40 Could you convert this test to utilize \|assert_sel Could you convert this test to utilize \|assert_selection()\|? I suggest you to be in a separate patch. yosin_UTC9 2016/11/30 03:18:51 It helps us what this CL changes behavior. You can Show quoted text On 2016/11/30 at 01:48:40, Yosi_UTC9 wrote: > Could you convert this test to utilize \|assert_selection()\|? > I suggest you to be in a separate patch. It helps us what this CL changes behavior. You can create dependency patches to review same time and commit sequencally. http://dev.chromium.org/developers/how-tos/get-the-code/working-with-branches
3 \| <i>	3 \| <i>

4 \| "	4 \| "

5 <#selection-anchor>Will select from here	5 <#selection-anchor>Will select from here"

	6 \| <br>

	7 \| "

6 "	8 "

7 \| <br>

8 \| <i>	9 \| <i>

9 \| "	10 \| "

10 until here.<#selection-focus>	11 until here.<#selection-focus>

11 "	12 "

12 \| <div>	13 \| <div>

13 \| contenteditable="false"	14 \| contenteditable="false"

14 \| "	15 \| "

15 over this contenteditable=false div	16 over this contenteditable=false div

16 "	17 "

OLD	NEW

OLD	NEW
1 formatblock on selection with a contenteditable="false" child.	1 formatblock on selection with a contenteditable="false" child.

2 \| <h1>	2 \| <h1>
	yosin_UTC9 2016/11/30 01:48:40 Could you convert this test to utilize \|assert_sel Could you convert this test to utilize \|assert_selection()\|? I suggest you to be in a separate patch. yosin_UTC9 2016/11/30 03:18:51 It helps us what this CL changes behavior. You can Show quoted text On 2016/11/30 at 01:48:40, Yosi_UTC9 wrote: > Could you convert this test to utilize \|assert_selection()\|? > I suggest you to be in a separate patch. It helps us what this CL changes behavior. You can create dependency patches to review same time and commit sequencally. http://dev.chromium.org/developers/how-tos/get-the-code/working-with-branches
3 \| <i>	3 \| <i>

4 \| "	4 \| "

5 <#selection-anchor>Will select from here	5 <#selection-anchor>Will select from here"

	6 \| <br>

	7 \| "

6 "	8 "

7 \| <br>

8 \| <i>	9 \| <i>

9 \| "	10 \| "

10 until here.<#selection-focus>	11 until here.<#selection-focus>

11 "	12 "

12 \| <div>	13 \| <div>

13 \| contenteditable="false"	14 \| contenteditable="false"

14 \| "	15 \| "

15 over this contenteditable=false div	16 over this contenteditable=false div

16 "	17 "

OLD	NEW