Issue 2532353002: Dispose AnalysisContext(s) used to resynthesize CompilationUnitElement(s) for IndexResult(s).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2532353002: Dispose AnalysisContext(s) used to resynthesize CompilationUnitElement(s) for IndexResult(s). (Closed)

Created:
4 years ago by scheglov

Modified:
4 years ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Dispose AnalysisContext(s) used to resynthesize CompilationUnitElement(s) for IndexResult(s). Otherwise we end up with references from SDK cache partitions to the context private partitions, which reference AnalysisContext(s). R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/987ed0661c21477fc3ea302b45871716b5a1721c

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View		1 chunk	+8 lines, -3 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

4 years ago (2016-11-29 15:18:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
987ed0661c21477fc3ea302b45871716b5a1721c (presubmit successful).