Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2532333003: MIPS64: Optimize load followed by shift (Closed)

Created:
4 years ago by ivica.bogosavljevic
Modified:
4 years ago
Reviewers:
dusan.simicic, ilija.pavlovic, miran.karic, miran.karic, Ilija.Pavlovic1
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Optimize load followed by shift Turbofan uses 64-bit load followed by 32 bit arithmetic shift when loading higher 32 bits of 64-bit value. We simplify this by loading higher 32 bits directly. BUG= Committed: https://crrev.com/d542b077cec0712090149a6f6546ae851a716df8 Cr-Commit-Position: refs/heads/master@{#41455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M src/compiler/mips64/instruction-selector-mips64.cc View 5 chunks +24 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ivica.bogosavljevic
PTAL
4 years ago (2016-11-29 16:05:39 UTC) #2
Ilija.Pavlovic1
lgtm
4 years ago (2016-11-30 10:04:52 UTC) #4
miran.karic
lgtm
4 years ago (2016-12-02 09:36:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532333003/1
4 years ago (2016-12-02 13:41:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 14:05:55 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-02 14:06:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d542b077cec0712090149a6f6546ae851a716df8
Cr-Commit-Position: refs/heads/master@{#41455}

Powered by Google App Engine
This is Rietveld 408576698