Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 25323003: Mojo: Optimize VerifyUserPointer(). (Closed)

Created:
7 years, 2 months ago by viettrungluu
Modified:
7 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman
Visibility:
Public.

Description

Mojo: Optimize VerifyUserPointer(). Gets rid of run-time division. In the new empty read test, goes from ~8.7 million iterations/second to ~9.7 million iterations/second (and in perf makes VerifyUserPointer() go from ~10% to ~0.5%). R=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -18 lines) Patch
M mojo/public/tests/system_core_perftest.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M mojo/system/core_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/core_test_base.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/system/memory.h View 1 chunk +21 lines, -5 lines 0 comments Download
M mojo/system/memory.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M mojo/system/message_pipe.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
viettrungluu
7 years, 2 months ago (2013-09-30 19:08:42 UTC) #1
darin (slow to review)
LGTM
7 years, 2 months ago (2013-09-30 21:09:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/25323003/1
7 years, 2 months ago (2013-10-01 22:18:20 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-01 23:16:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/25323003/1
7 years, 2 months ago (2013-10-01 23:17:55 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-01 23:49:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/25323003/1
7 years, 2 months ago (2013-10-02 00:16:02 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-02 00:48:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/25323003/1
7 years, 2 months ago (2013-10-02 04:30:23 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 07:42:25 UTC) #10
Message was sent while issue was closed.
Change committed as 226422

Powered by Google App Engine
This is Rietveld 408576698