Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2532283002: Minor test cleanup of table-cell-changes-to-colgroup.html (Closed)

Created:
4 years ago by wkorman
Modified:
4 years ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor test cleanup of table-cell-changes-to-colgroup.html To improve readability/maintenance. BUG=666800 Committed: https://crrev.com/1c1e8e1a602add612215503e633b003737c15d29 Cr-Commit-Position: refs/heads/master@{#434799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -26 lines) Patch
M third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup.html View 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup-expected.html View 1 chunk +15 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
wkorman
Tested with recent fix reverted on asan build and issue we were aiming to fix ...
4 years ago (2016-11-28 22:04:15 UTC) #4
Xianzhu
lgtm
4 years ago (2016-11-28 22:05:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532283002/1
4 years ago (2016-11-28 22:07:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 00:39:46 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-29 00:47:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c1e8e1a602add612215503e633b003737c15d29
Cr-Commit-Position: refs/heads/master@{#434799}

Powered by Google App Engine
This is Rietveld 408576698