Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2532253002: Revert of Improve fallback for Burmese with leading punctuation + spacing mark (Closed)

Created:
4 years ago by Marijn Kruisselbrink
Modified:
4 years ago
Reviewers:
drott, kojii, eae, behdad
CC:
ajuma+watch_chromium.org, apavlov+blink_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, danakj+watch_chromium.org, devtools-reviews_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pdr+graphicswatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Improve fallback for Burmese with leading punctuation + spacing mark (patchset #3 id:30009 of https://codereview.chromium.org/2530153002/ ) Reason for revert: This seems to be causing test failures for fast/text/international/text-spliced-font.html on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/17622 Original issue's description: > Improve fallback for Burmese with leading punctuation + spacing mark > > Issue 618178 describes an example where a Burmese text run starts with a > leading punctuation character followed by a combining spacing mark. This > grapheme cannot be shaped with the default font, since Times for example > cannot display the combination of a left quote with a Burmese combining > mark. Our fallback code attempts to find a fallback font based on the > first character at the beginning of an extracted unshaped sub-run, which > does not lead to finding a font suitable for Myanmar text in this case. > So in a way it runs into a fallback trap, where no fallback hint helps > to find the right fallback font and the whole run ends up as notdef > glyphs. > > This CL attempts to resolve this by looking for a better fallback hint > character, which is not script common or inherited, if such is > available. This improves the situation for the Burmese text from the > issue report. > > In addition, as a better fix we should give higher importance to the > locale information in font fallback, filed as issue 668706. > > BUG=618178 > R=eae,kojii,behdad > > Committed: https://crrev.com/d9280a5e951415e1b2c6c7958adda19b731a99fa > Cr-Commit-Position: refs/heads/master@{#434665} TBR=behdad@chromium.org,eae@chromium.org,kojii@chromium.org,drott@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618178 Committed: https://crrev.com/1b8f4236e2dbf4e07bf0171300003168633b8660 Cr-Commit-Position: refs/heads/master@{#434719}

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
Marijn Kruisselbrink
Created Revert of Improve fallback for Burmese with leading punctuation + spacing mark
4 years ago (2016-11-28 21:06:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532253002/1
4 years ago (2016-11-28 21:07:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 21:09:12 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-28 21:13:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b8f4236e2dbf4e07bf0171300003168633b8660
Cr-Commit-Position: refs/heads/master@{#434719}

Powered by Google App Engine
This is Rietveld 408576698