Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 2532243005: Fix more integer underflow cases in base::Time::FromExploded. (Closed)

Created:
2 years, 10 months ago by davidben
Modified:
2 years, 10 months ago
Reviewers:
miu
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix more integer underflow cases in base::Time::FromExploded. https://codereview.chromium.org/2405453002 fixed some of it, but there were still others. The subtractions to pick a different starting point for the year and month may also underflow. BUG=668445 Committed: https://crrev.com/63a9a63fa1c229c3eb062ad5339984a165301384 Cr-Commit-Position: refs/heads/master@{#435073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M base/time/time_posix.cc View 2 chunks +21 lines, -11 lines 0 comments Download
M base/time/time_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
davidben
2 years, 10 months ago (2016-11-29 19:36:17 UTC) #5
miu
lgtm. Thanks! :) BTW, if you or anyone else are interested, there's https://crbug.com/669625 as well.
2 years, 10 months ago (2016-11-29 19:46:44 UTC) #6
davidben
On 2016/11/29 19:46:44, miu wrote: > lgtm. Thanks! :) > > BTW, if you or ...
2 years, 10 months ago (2016-11-29 19:56:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532243005/1
2 years, 10 months ago (2016-11-29 19:57:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 10 months ago (2016-11-29 20:38:58 UTC) #13
commit-bot: I haz the power
2 years, 10 months ago (2016-11-29 20:44:20 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63a9a63fa1c229c3eb062ad5339984a165301384
Cr-Commit-Position: refs/heads/master@{#435073}

Powered by Google App Engine
This is Rietveld 408576698