Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc

Issue 2532243002: Stack sampling profiler: fix module read validation failures (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/public/cpp/call_stack_profile_struct_traits.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc
diff --git a/components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc b/components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc
index 22265a6182249befd8498621825a99c7f69d02d1..f1bbf34dc213f0dcc2cb38a7d8b9cad24fcfc367 100644
--- a/components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc
+++ b/components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc
@@ -130,18 +130,6 @@ TEST_F(CallStackProfileStructTraitsTest, Module) {
Module(0x10, "", base::FilePath(base::FilePath::kCurrentDirectory)),
true
},
- // Module id at the length limit.
- {
- Module(0x10, std::string(40, ' '),
- base::FilePath(base::FilePath::kCurrentDirectory)),
- true
- },
- // Module id beyond the length limit.
- {
- Module(0x10, std::string(41, ' '),
- base::FilePath(base::FilePath::kCurrentDirectory)),
- false
- },
};
for (const SerializeCase& input : serialize_cases) {
« no previous file with comments | « components/metrics/public/cpp/call_stack_profile_struct_traits.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698