Stack sampling profiler: fix module read validation failures

Stack sampling profiler: fix module read validation failures

The current module id length check excludes some third party modules
that are not as well behaved as expected. Remove it so we can transfer
profiles containing these modules.

BUG=659903
Committed: https://crrev.com/efee7e706efa008ec5e984bea0abfc2a34609381
Cr-Commit-Position: refs/heads/master@{#434757}

[Mike Wittman, 2016-11-28 20:03:09]

wittman@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-11-28 20:11:07]

On 2016/11/28 20:03:10, Mike Wittman wrote:

Can you remind me why we were checking this in the first place?  Otherwise LGTM.

[Mike Wittman, 2016-11-28 20:21:21]

On 2016/11/28 20:11:07, Tom Sepez wrote:
> On 2016/11/28 20:03:10, Mike Wittman wrote:
> 
> Can you remind me why we were checking this in the first place?  Otherwise
LGTM.

It was an attempt to ensure that the ids looked more or less "reasonable". These
are treated as opaque values so I don't think there's any security value to the
check.

[Mike Wittman, 2016-11-28 20:21:26]

The CQ bit was checked by wittman@chromium.org

[commit-bot: I haz the power, 2016-11-28 20:23:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-28 20:24:45]

> > Can you remind me why we were checking this in the first place?  Otherwise
> LGTM.
> 
> It was an attempt to ensure that the ids looked more or less "reasonable".
These
> are treated as opaque values so I don't think there's any security value to
the
> check.

Thanks, that's what I figured.

[commit-bot: I haz the power, 2016-11-28 22:53:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480364486450020, "parent_rev":
"ea6604f06291519daf73eb41119ecc4b6a112773", "commit_rev":
"6bc208198e0d3f0b4c09475368cdf1c59a3e3050"}

[commit-bot: I haz the power, 2016-11-28 22:54:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-28 22:58:10]

Description was changed from

==========
Stack sampling profiler: fix module read validation failures

The current module id length check excludes some third party modules
that are not as well behaved as expected. Remove it so we can transfer
profiles containing these modules.

BUG=659903
==========

to

==========
Stack sampling profiler: fix module read validation failures

The current module id length check excludes some third party modules
that are not as well behaved as expected. Remove it so we can transfer
profiles containing these modules.

BUG=659903

Committed: https://crrev.com/efee7e706efa008ec5e984bea0abfc2a34609381
Cr-Commit-Position: refs/heads/master@{#434757}
==========

[commit-bot: I haz the power, 2016-11-28 22:58:11]

Patchset 1 (id:??) landed as
https://crrev.com/efee7e706efa008ec5e984bea0abfc2a34609381
Cr-Commit-Position: refs/heads/master@{#434757}