Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2532233002: mac: Don't allow animations on FullscreenLowPowerWindow. (Closed)

Created:
4 years ago by erikchen
Modified:
4 years ago
Reviewers:
ccameron
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Don't allow animations on FullscreenLowPowerWindow. The window is supposed to instantly pop behind and in front of the main browser window. BUG=667511 Committed: https://crrev.com/ec1c7cbfff53d770a16d007de3c665a41c035181 Cr-Commit-Position: refs/heads/master@{#434800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
erikchen
ccameron: Please review.
4 years ago (2016-11-28 22:40:06 UTC) #2
ccameron
lgtm
4 years ago (2016-11-28 22:43:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532233002/1
4 years ago (2016-11-28 23:11:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 00:44:47 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-29 00:55:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec1c7cbfff53d770a16d007de3c665a41c035181
Cr-Commit-Position: refs/heads/master@{#434800}

Powered by Google App Engine
This is Rietveld 408576698