Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2532223002: Instant Apps: Allow custom tab redirects to Instant Apps. (Closed)

Created:
4 years ago by Maria
Modified:
4 years ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instant Apps: Allow custom tab redirects to Instant Apps. Usually custom tabs force-load URLs or redirects to URLs that can be handled by apps inside custom tabs. For instant-apps enabled clients override the default behaviour and launch the instant app, if possible. BUG=659301 Committed: https://crrev.com/0d4f64f504986b0ef87efd1275935c30a9416512 Cr-Commit-Position: refs/heads/master@{#434714}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -15 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java View 2 chunks +23 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabRedirectHandler.java View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java View 1 4 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Maria
4 years ago (2016-11-28 19:31:13 UTC) #2
Ted C
lgtm https://codereview.chromium.org/2532223002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java (right): https://codereview.chromium.org/2532223002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java#newcode541 chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java:541: remove extra line here
4 years ago (2016-11-28 19:34:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532223002/20001
4 years ago (2016-11-28 19:38:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-28 20:52:23 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-28 20:54:15 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d4f64f504986b0ef87efd1275935c30a9416512
Cr-Commit-Position: refs/heads/master@{#434714}

Powered by Google App Engine
This is Rietveld 408576698