Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 2532213002: [Origin Trials] Rename confusing 'global' variable (Closed)

Created:
4 years ago by iclelland
Modified:
4 years ago
Reviewers:
haraken, chasej, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Origin Trials] Rename confusing 'global' variable The name of variable was causing no end of confusion about when it should be passed into the various install* methods for origin trials, and when a dummy object should be passed instead. Renamed to the more sensible 'instanceObject', as a counterpart to 'interfaceObject' and 'prototypeObject', and now only instantiate it when necessary (in Window and WorkerGlobalScope blocks). Committed: https://crrev.com/1ec185eb4d99a84648870f88c1962b076e3d818a Cr-Commit-Position: refs/heads/master@{#434996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp View 3 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
iclelland
+r chasej for Origin Trials
4 years ago (2016-11-28 19:04:34 UTC) #3
chasej
lgtm
4 years ago (2016-11-28 20:06:08 UTC) #5
haraken
LGTM
4 years ago (2016-11-29 01:48:56 UTC) #8
Yuki
LGTM. :)
4 years ago (2016-11-29 01:57:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532213002/1
4 years ago (2016-11-29 15:25:50 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 15:30:53 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-29 15:33:13 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ec185eb4d99a84648870f88c1962b076e3d818a
Cr-Commit-Position: refs/heads/master@{#434996}

Powered by Google App Engine
This is Rietveld 408576698