Search for top-level elements and class members.

Search for top-level elements and class members.

No search for imports, import prefixes, libraries and units yet.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/27a32754955886d65f0b73a803de8c45af44c961

[Paul Berry, 2016-11-28 18:50:07]

lgtm

[Brian Wilkerson, 2016-11-28 18:52:08]

lgtm

https://codereview.chromium.org/2532203002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/search.dart (right):

https://codereview.chromium.org/2532203002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/search.dart:19: Element
_getEnclosingElement(CompilationUnitElement unitElement, int offset) {
Not that it matters much because they are both private, but I'd prefer to see
this as a static method on _ContainingElementFinder so that if it's made into a
more visible utility class this method will also be made more visible.

https://codereview.chromium.org/2532203002/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/analysis/search_test.dart (right):

https://codereview.chromium.org/2532203002/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/search_test.dart:72:
fail_test_searchReferences_CompilationUnitElement() async {
Use @failingTest?

[scheglov, 2016-11-28 19:09:02]

Description was changed from

==========
Search for top-level elements and class members.

No search for imports, import prefixes, libraries and units yet.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Search for top-level elements and class members.

No search for imports, import prefixes, libraries and units yet.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/27a32754955886d65f0b73a803de8c45af44c961
==========

[scheglov, 2016-11-28 19:09:03]

Committed patchset #1 (id:1) manually as
27a32754955886d65f0b73a803de8c45af44c961 (presubmit successful).