Add support in gclient for pre-DEPS hooks

tests/gclient_smoketest.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Smoke tests for gclient.py.
 
 Shell out 'gclient' and run basic conformance tests.
 
 This test assumes GClientSmokeBase.URL_BASE is valid.
@@ skipping 1049 matching lines @@
                             ['running', 'running'])
     self.assertEquals(1, len(out[0]))
     self.assertEquals(1, len(out[1]))
     tree = self.mangle_git_tree(('repo_1@2', 'src'),
                                 ('repo_2@1', 'src/repo2'),
                                 ('repo_3@2', 'src/repo2/repo_renamed'))
     tree['src/git_hooked1'] = 'git_hooked1'
     tree['src/git_hooked2'] = 'git_hooked2'
     self.assertTree(tree)
 
+  def testPreDepsHooks(self):
+    if not self.enabled:
+      return
+    self.gclient(['config', self.git_base + 'repo_5', '--name', 'src'])
+    expectation = [
+        ('running', self.root_dir),                 # git clone repo_5
+        ('running', self.root_dir + '/src'),        # git checkout src
+        ('running', self.root_dir),                 # pre-deps hook
+        ('running', self.root_dir),                 # git clone repo_1
+        ('running', self.root_dir + '/src/repo1'),  # git checkout repo1
+        ('running', self.root_dir),                 # git clone repo_1
+        ('running', self.root_dir + '/src/repo2'),  # git checkout repo2
+    ]
+    out = self.parseGclient(['sync', '--deps', 'mac', '--jobs=1',
+                             '--revision', 'src@' + self.githash('repo_5', 2)],
+                            expectation)
+    self.assertEquals(2, len(out[2]))
+    self.assertEquals('pre-deps hook', out[2][1])
+    tree = self.mangle_git_tree(('repo_5@2', 'src'),
+                                ('repo_1@2', 'src/repo1'),
+                                ('repo_2@1', 'src/repo2')
+                                )
+    tree['src/git_pre_deps_hooked'] = 'git_pre_deps_hooked'
+    self.assertTree(tree)
+
+    os.remove(join(self.root_dir, 'src', 'git_pre_deps_hooked'))
+
+    # Pre-DEPS hooks run with runhooks.
+    self.gclient(['runhooks', '--deps', 'mac'])
+    tree = self.mangle_git_tree(('repo_5@2', 'src'),
+                                ('repo_1@2', 'src/repo1'),
+                                ('repo_2@1', 'src/repo2')
+                                )
+    tree['src/git_pre_deps_hooked'] = 'git_pre_deps_hooked'
+    self.assertTree(tree)
+
+    os.remove(join(self.root_dir, 'src', 'git_pre_deps_hooked'))
+
+    # Pre-DEPS hooks run with --nohooks.
+    self.gclient(['sync', '--deps', 'mac', '--nohooks',
+                  '--revision', 'src@' + self.githash('repo_5', 2)])
+    tree = self.mangle_git_tree(('repo_5@2', 'src'),
+                                ('repo_1@2', 'src/repo1'),
+                                ('repo_2@1', 'src/repo2')
+                                )
+    tree['src/git_pre_deps_hooked'] = 'git_pre_deps_hooked'
+    self.assertTree(tree)
+
+    os.remove(join(self.root_dir, 'src', 'git_pre_deps_hooked'))
+
+    # Pre-DEPS hooks don't run with --noprehooks
+    self.gclient(['sync', '--deps', 'mac', '--noprehooks',
+                  '--revision', 'src@' + self.githash('repo_5', 2)])
+    tree = self.mangle_git_tree(('repo_5@2', 'src'),
+                                ('repo_1@2', 'src/repo1'),
+                                ('repo_2@1', 'src/repo2')
+                                )
+    self.assertTree(tree)
+
+  def testPreDepsHooksError(self):
+    if not self.enabled:
+      return
+    self.gclient(['config', self.git_base + 'repo_5', '--name', 'src'])
+    expectated_stdout = [
+        ('running', self.root_dir),                 # git clone repo_5
+        ('running', self.root_dir + '/src'),        # git checkout src
+        ('running', self.root_dir),                 # pre-deps hook
+        ('running', self.root_dir),                 # pre-deps hook (fails)
+    ]
+    expected_stderr = ('Error: Command /usr/bin/python -c import sys; '
+                       'sys.exit(1) returned non-zero exit status 1 in %s\n'
+                       % self.root_dir)
+    stdout, stderr, retcode = self.gclient(['sync', '--deps', 'mac', '--jobs=1',
+                                            '--revision',
+                                            'src@' + self.githash('repo_5', 3)])
+    self.assertEquals(stderr, expected_stderr)
+    self.assertEquals(2, retcode)
+    self.checkBlock(stdout, expectated_stdout)
+
   def testRevInfo(self):
     if not self.enabled:
       return
     self.gclient(['config', self.git_base + 'repo_1', '--name', 'src'])
     self.gclient(['sync', '--deps', 'mac'])
     results = self.gclient(['revinfo', '--deps', 'mac'])
     out = ('src: %(base)srepo_1\n'
            'src/repo2: %(base)srepo_2@%(hash2)s\n'
            'src/repo2/repo_renamed: %(base)srepo_3\n' %
           {
@@ skipping 288 matching lines @@
 
   if '-c' in sys.argv:
     COVERAGE = True
     sys.argv.remove('-c')
     if os.path.exists('.coverage'):
       os.remove('.coverage')
     os.environ['COVERAGE_FILE'] = os.path.join(
         os.path.dirname(os.path.dirname(os.path.abspath(__file__))),
         '.coverage')
   unittest.main()