Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1952)

Unified Diff: build/config/chromecast/BUILD.gn

Issue 2532193002: Enable -Werror for links in chromecast builds. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/chromecast/BUILD.gn
diff --git a/build/config/chromecast/BUILD.gn b/build/config/chromecast/BUILD.gn
index f1cbfe61946fb68e18ab195dc1e3e9aae4012ad7..6c208a1b7acfb214a9310d9345bd25e48b2669b3 100644
--- a/build/config/chromecast/BUILD.gn
+++ b/build/config/chromecast/BUILD.gn
@@ -8,15 +8,20 @@ assert(is_chromecast)
config("static_config") {
ldflags = [
- # We want to statically link libstdc++/libgcc.
- "-static-libstdc++",
- "-static-libgcc",
-
# Don't allow visible symbols from libraries that contain
# assembly code with symbols that aren't hidden properly.
# http://b/26390825
"-Wl,--exclude-libs=libffmpeg.a",
]
+
+ if (!is_android) {
+ ldflags += [
+ # We want to statically link libstdc++/libgcc on Linux.
+ # (On Android, libstdc++ and libgcc aren't used.)
+ "-static-libstdc++",
+ "-static-libgcc",
+ ]
+ }
}
config("ldconfig") {
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698