Enable -Werror for links in chromecast builds.

Enable -Werror for links in chromecast builds.

BUG=669076
Committed: https://crrev.com/21b2e5f86e4ac1ecd5bcc3da195cf2f7fd427eff
Cr-Commit-Position: refs/heads/master@{#434755}

[Nico, 2016-11-28 17:42:44]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 17:43:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-11-28 17:56:49]

thakis@chromium.org changed reviewers:
+ antz@chromium.org, bcf@chromium.org, slan@chromium.org

[Nico, 2016-11-28 17:56:50]

Not sure who's the best reviewer here (no OWNERS file in
build/config/chromecast)

[slan, 2016-11-28 18:00:00]

lgtm

Nico, do you remember why we disabled this on Cast builds in the first place?

[Nico, 2016-11-28 18:03:24]

On 2016/11/28 18:00:00, slan wrote:
> lgtm
> 
> Nico, do you remember why we disabled this on Cast builds in the first place?

-Werror for links? We just never had it enabled anywhere, mostly due to
oversight. I turned it on last week but disabled it on cast and asan since the
trybots didn't come green there and I figured I'd investigate and fix those in a
follow-up. This is that follow-up. (Also see bug)

[Nico, 2016-11-28 18:03:27]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2016-11-28 18:03:30]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-11-28 18:03:40]

Oh, and thanks for the fast review :-)

[commit-bot: I haz the power, 2016-11-28 18:03:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-11-28 18:27:28]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-11-28 18:27:28]

The patchset sent to the CQ was uploaded after l-g-t-m from slan@chromium.org
Link to the patchset: https://codereview.chromium.org/2532193002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-28 18:28:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bcf, 2016-11-28 19:09:55]

lgtm

[commit-bot: I haz the power, 2016-11-28 19:43:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 19:43:48]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Nico, 2016-11-28 20:02:13]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-11-28 20:04:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 22:51:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480363333854920,
"parent_rev": "4598a3eedcc8ce60daeaf782849d41bb8f728a85", "commit_rev":
"bd983934046837009bef85d14342d97c09b116d2"}

[commit-bot: I haz the power, 2016-11-28 22:52:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-28 22:55:24]

Description was changed from

==========
Enable -Werror for links in chromecast builds.

BUG=669076
==========

to

==========
Enable -Werror for links in chromecast builds.

BUG=669076

Committed: https://crrev.com/21b2e5f86e4ac1ecd5bcc3da195cf2f7fd427eff
Cr-Commit-Position: refs/heads/master@{#434755}
==========

[commit-bot: I haz the power, 2016-11-28 22:55:25]

Patchset 3 (id:??) landed as
https://crrev.com/21b2e5f86e4ac1ecd5bcc3da195cf2f7fd427eff
Cr-Commit-Position: refs/heads/master@{#434755}