Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Issue 2532173002: Cleanup: Remove partial InstantSearch implementation on Android (Closed)

Created:
4 years ago by Marc Treib
Modified:
4 years ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove partial InstantSearch implementation on Android This feature was abandoned long ago and never launched. The FieldTrials which could have enabled it are being removed in https://codereview.chromium.org/2526753002/. BUG=627747 Committed: https://crrev.com/6e412f922e388794d1ef14269e8e1d53dc2814ee Cr-Commit-Position: refs/heads/master@{#435120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -144 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/android/omnibox/autocomplete_controller_android.cc View 3 chunks +1 line, -29 lines 0 comments Download
M chrome/browser/android/tab_android.h View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 8 chunks +0 lines, -81 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Marc Treib
PTAL!
4 years ago (2016-11-29 15:01:41 UTC) #3
Bernhard Bauer
LGTM!
4 years ago (2016-11-29 15:58:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532173002/1
4 years ago (2016-11-29 23:43:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 01:57:53 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-30 02:04:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e412f922e388794d1ef14269e8e1d53dc2814ee
Cr-Commit-Position: refs/heads/master@{#435120}

Powered by Google App Engine
This is Rietveld 408576698