Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2532153002: Cleanup in HttpNetworkTransactionSSLTest. (Closed)

Created:
4 years ago by Bence
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup in HttpNetworkTransactionSSLTest. * Since all tests use a TokenBindingSSLConfigService, create one in SetUp(), instead of creating a TLS10SSLConfigService that is destroyed at the beginning of each test. * Remove unused classes TLS1?SSLConfigService. * Remove unused GetServerSSLConfig(). * In HttpNetworkTransaction, defriend HttpNetworkTransactionSSLTest and test cases that do not access private member. * git cl format. Committed: https://crrev.com/1f61cdf390c95e43b5de30bc8bdc664191dbfb6e Cr-Commit-Position: refs/heads/master@{#434687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -56 lines) Patch
M net/http/http_network_transaction.h View 1 chunk +5 lines, -14 lines 0 comments Download
M net/http/http_network_transaction_ssl_unittest.cc View 6 chunks +1 line, -42 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Bence
Ryan: PTAL. Thank you.
4 years ago (2016-11-28 17:33:13 UTC) #6
Ryan Hamilton
lgtm Nice!
4 years ago (2016-11-28 17:45:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532153002/1
4 years ago (2016-11-28 17:58:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 18:04:13 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-28 18:06:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f61cdf390c95e43b5de30bc8bdc664191dbfb6e
Cr-Commit-Position: refs/heads/master@{#434687}

Powered by Google App Engine
This is Rietveld 408576698