Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 2532133003: [wrapper-tracing] CHECK against isWrapperTracingForbidden instead of isGCForbidden (Closed)
Patch Set: Relax check since we actually only have to worry about mixin ctors Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
index 7e46e69868941673a4cb422f1bdbec5b3ba93dd8..7c8faf4e3e67ac86c58877669bd52d8a21bd5514 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
@@ -629,6 +629,7 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::callFunction(
TRACE_EVENT_BEGIN1("devtools.timeline", "FunctionCall", "data",
InspectorFunctionCallEvent::data(context, function));
+ CHECK(!ThreadState::current()->isWrapperTracingForbidden());
v8::MicrotasksScope microtasksScope(isolate,
v8::MicrotasksScope::kRunMicrotasks);
PerformanceMonitor::willCallFunction(context);
@@ -650,6 +651,7 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::callInternalFunction(
v8::Local<v8::Value> args[],
v8::Isolate* isolate) {
TRACE_EVENT0("v8", "v8.callFunction");
+ CHECK(!ThreadState::current()->isWrapperTracingForbidden());
v8::MicrotasksScope microtasksScope(isolate,
v8::MicrotasksScope::kDoNotRunMicrotasks);
v8::MaybeLocal<v8::Value> result =

Powered by Google App Engine
This is Rietveld 408576698