[wrapper-tracing] CHECK against isWrapperTracingForbidden instead of isGCForbidden

[wrapper-tracing] CHECK against isWrapperTracingForbidden instead of isGCForbidden

We only require proper tracing functionality but don't trigger any collection on
the Oilpan heap. Introduce a new getter ThreadState::isWrapperTracingForbidden()
for that purpose.

Drive-by: CHECK on calling v8::Function that we are indeed allowed to trace
wrappers.

BUG=chromium:468240
Committed: https://crrev.com/9d12bf2df018d41a99903ff29c9b729a4ad829cb
Cr-Commit-Position: refs/heads/master@{#434994}

[Michael Lippautz, 2016-11-29 10:13:52]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[Michael Lippautz, 2016-11-29 10:14:16]

Description was changed from

==========
[wrapper-tracing] CHECK against GC forbidden scope when calling a v8::Function

BUG=
==========

to

==========
[wrapper-tracing] CHECK against GC forbidden scope when calling a v8::Function

BUG=chromium:468240
==========

[commit-bot: I haz the power, 2016-11-29 10:14:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 11:02:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 11:02:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Michael Lippautz, 2016-11-29 12:28:30]

Description was changed from

==========
[wrapper-tracing] CHECK against GC forbidden scope when calling a v8::Function

BUG=chromium:468240
==========

to

==========
[wrapper-tracing] CHECK against isWrapperTracingForbidden instead of
isGCForbidden

We only require proper tracing functionality but don't trigger any collection on
the Oilpan heap. Introduce a new
getter isWrapperTracingForbidden() for that purpose.

Drive-by: CHECK on calling v8::Function that we are indeed allowed to trace
wrappers.

BUG=chromium:468240
==========

[Michael Lippautz, 2016-11-29 12:28:57]

Description was changed from

==========
[wrapper-tracing] CHECK against isWrapperTracingForbidden instead of
isGCForbidden

We only require proper tracing functionality but don't trigger any collection on
the Oilpan heap. Introduce a new
getter isWrapperTracingForbidden() for that purpose.

Drive-by: CHECK on calling v8::Function that we are indeed allowed to trace
wrappers.

BUG=chromium:468240
==========

to

==========
[wrapper-tracing] CHECK against isWrapperTracingForbidden instead of
isGCForbidden

We only require proper tracing functionality but don't trigger any collection on
the Oilpan heap. Introduce a new getter ThreadState::isWrapperTracingForbidden()
for that purpose.

Drive-by: CHECK on calling v8::Function that we are indeed allowed to trace
wrappers.

BUG=chromium:468240
==========

[Michael Lippautz, 2016-11-29 12:30:50]

mlippautz@chromium.org changed reviewers:
+ haraken@chromium.org, hlopko@chromium.org

[Michael Lippautz, 2016-11-29 12:30:51]

PTAL. We probably can relax some of those CHECKS to DCHECKS once stabilized.

[Michael Lippautz, 2016-11-29 12:31:21]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 12:31:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-11-29 12:49:00]

LGTM

[Marcel Hlopko, 2016-11-29 13:41:54]

lgtm

[commit-bot: I haz the power, 2016-11-29 14:08:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 14:08:39]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Michael Lippautz, 2016-11-29 14:09:08]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2016-11-29 14:09:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 15:25:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480428548040930,
"parent_rev": "6d88b0902e66de7a4caf76e9a0e961e1399c97d2", "commit_rev":
"0032ac271890337ec866969382744b4219296bc5"}

[commit-bot: I haz the power, 2016-11-29 15:25:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 15:29:15]

Description was changed from

==========
[wrapper-tracing] CHECK against isWrapperTracingForbidden instead of
isGCForbidden

We only require proper tracing functionality but don't trigger any collection on
the Oilpan heap. Introduce a new getter ThreadState::isWrapperTracingForbidden()
for that purpose.

Drive-by: CHECK on calling v8::Function that we are indeed allowed to trace
wrappers.

BUG=chromium:468240
==========

to

==========
[wrapper-tracing] CHECK against isWrapperTracingForbidden instead of
isGCForbidden

We only require proper tracing functionality but don't trigger any collection on
the Oilpan heap. Introduce a new getter ThreadState::isWrapperTracingForbidden()
for that purpose.

Drive-by: CHECK on calling v8::Function that we are indeed allowed to trace
wrappers.

BUG=chromium:468240

Committed: https://crrev.com/9d12bf2df018d41a99903ff29c9b729a4ad829cb
Cr-Commit-Position: refs/heads/master@{#434994}
==========

[commit-bot: I haz the power, 2016-11-29 15:29:16]

Patchset 2 (id:??) landed as
https://crrev.com/9d12bf2df018d41a99903ff29c9b729a4ad829cb
Cr-Commit-Position: refs/heads/master@{#434994}