Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2532133002: Make minidump uploading test logic more useful to WebView. (Closed)

Created:
4 years ago by gsennton
Modified:
4 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make minidump uploading test logic more useful to WebView. Make minidump uploading test utility more useful/accessible to WebView to allow for testing the WebView-implementation of minidump uploading. BUG=665448 Committed: https://crrev.com/9cea744e442147ca0d9a7541ed7e79378aa0c9b6 Cr-Commit-Position: refs/heads/master@{#434933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -43 lines) Patch
M components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashTestCase.java View 4 chunks +56 lines, -1 line 0 comments Download
M components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
gsennton
Hey Ilya, this CL just makes some test utilities available to WebView. If you're interested/curious, ...
4 years ago (2016-11-28 14:49:44 UTC) #2
Ilya Sherman
lgtm, thanks
4 years ago (2016-11-29 03:25:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532133002/1
4 years ago (2016-11-29 08:53:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 09:18:32 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-29 09:34:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cea744e442147ca0d9a7541ed7e79378aa0c9b6
Cr-Commit-Position: refs/heads/master@{#434933}

Powered by Google App Engine
This is Rietveld 408576698