Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 253213003: Add a warning to the documentation of chrome.tabs.executeScript API (Closed)

Created:
6 years, 7 months ago by meacer
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add a warning to the documentation of chrome.tabs.executeScript API BUG=330111 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/extensions/api/tabs.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/webview_tag.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
meacer
This is a temporary addition to the docs until a solution for 330111 is found. ...
6 years, 7 months ago (2014-04-29 23:56:35 UTC) #1
not at google - send to devlin
lgtm better than nothing I suppose.
6 years, 7 months ago (2014-04-30 00:07:00 UTC) #2
meacer
On 2014/04/30 00:07:00, kalman wrote: > lgtm > > better than nothing I suppose. Thanks.
6 years, 7 months ago (2014-04-30 00:09:09 UTC) #3
meacer
The CQ bit was checked by meacer@chromium.org
6 years, 7 months ago (2014-04-30 00:09:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/253213003/1
6 years, 7 months ago (2014-04-30 00:11:56 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 00:54:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 00:54:49 UTC) #7
meacer
The CQ bit was checked by meacer@chromium.org
6 years, 7 months ago (2014-04-30 00:57:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/253213003/1
6 years, 7 months ago (2014-04-30 01:00:02 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 01:02:07 UTC) #10
Message was sent while issue was closed. 
Change committed as 267017

Powered by Google App Engine
This is Rietveld 408576698