Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: tools/testing/dart/test_options.dart

Issue 2532123002: Add more flags to the blacklist of reproduction commands (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index 68dad1775efe6da173b21740369c6f77835ccb8c..83856fe5966737897fe3de078788e52fceafd297 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -608,24 +608,28 @@ Note: currently only implemented for dart2js.''',
// For printing out reproducing command lines, we don't want to add these
// options.
Set<String> _blacklistedOptions = new Set<String>.from([
- 'progress',
- 'failure-summary',
- 'step_name',
- 'report',
- 'tasks',
- 'verbose',
- 'time',
+ 'append_logs',
+ 'build_directory',
+ 'chrome',
+ 'copy_coredumps',
'dart',
- 'drt',
'dartium',
+ 'drt',
+ 'exclude_suite',
+ 'failure-summary',
'firefox',
- 'chrome',
- 'safari',
- 'build_directory',
- 'append_logs',
'local_ip',
+ 'progress',
+ 'report',
+ 'safari',
'shard',
'shards',
+ 'step_name',
+ 'tasks',
+ 'time',
+ 'verbose',
+ 'write_debug_log',
+ 'write_test_outcome_log',
]);
List<String> _constructReproducingCommandArguments(Map config) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698