Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2532103004: [turbofan] Remove bytecode analysis unit test (Closed)

Created:
4 years ago by Leszek Swirski
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove bytecode analysis unit test Blocking roll: https://codereview.chromium.org/2537173002/ NOTRY=true Committed: https://crrev.com/7d10f69ca36dc5d5c4d6138a9b21245add11eb9c Cr-Commit-Position: refs/heads/master@{#41376}

Patch Set 1 #

Patch Set 2 : Remove from gn/gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -417 lines) Patch
M test/unittests/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D test/unittests/compiler/bytecode-analysis-unittest.cc View 1 chunk +0 lines, -415 lines 0 comments Download
M test/unittests/unittests.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
Leszek Swirski
4 years ago (2016-11-30 08:50:49 UTC) #2
Michael Hablich
On 2016/11/30 08:50:49, Leszek Swirski wrote: lgtm
4 years ago (2016-11-30 08:54:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532103004/20001
4 years ago (2016-11-30 09:00:25 UTC) #5
Michael Achenbach
On 2016/11/30 08:54:11, Hablich wrote: > On 2016/11/30 08:50:49, Leszek Swirski wrote: > > lgtm ...
4 years ago (2016-11-30 09:00:45 UTC) #6
Michael Achenbach
lgtm
4 years ago (2016-11-30 09:01:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532103004/20001
4 years ago (2016-11-30 09:01:47 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 09:03:37 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-30 09:04:12 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7d10f69ca36dc5d5c4d6138a9b21245add11eb9c
Cr-Commit-Position: refs/heads/master@{#41376}

Powered by Google App Engine
This is Rietveld 408576698