Add support for components/ntp_tiles in InstantService

components/ntp_tiles/ntp_tile.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_TILES_NTP_TILE_H_
 #define COMPONENTS_NTP_TILES_NTP_TILE_H_
 
 #include <vector>
 
 #include "base/files/file_path.h"
@@ skipping 19 matching lines @@
 
 // A suggested site shown on the New Tab Page.
 struct NTPTile {
   base::string16 title;
   GURL url;
   NTPTileSource source;
 
   // Only valid for source == WHITELIST (empty otherwise).
   base::FilePath whitelist_icon_path;
 
+  // Only valid for source == SUGGESTIONS_SERVICE (empty otherwise).

[sfiera, 2016/11/28 13:11:12]

Are they always non-empty for the suggestions service? What happens if a site
doesn't have a favicon, or we haven't yet visited it to produce the thumbnail?

[Marc Treib, 2016/11/28 13:19:29]

I believe the favicon URL always points to some chrome://favicons/ URL, and may
or may not 404.

The thumbnail URL can point to a local chrome:// (or chrome-search://, I forget)
URL and/or an online URL pointing to a thumbnail service. I think it can be
empty in some cases.

[sfiera, 2016/11/29 10:24:03]

I would appreciate this kind of information in the comment :)

[Marc Treib, 2016/11/29 15:20:13]

Not sure how much of this we want to "fixate" in the API - e.g. the favicon URL
may be passed down from the server (though that doesn't happen in practice these
days AFAIK).
Well, I tried to add some info, PTAL.

+  GURL thumbnail_url;
+  GURL favicon_url;
+
   NTPTile();
   NTPTile(const NTPTile&);
   ~NTPTile();
 };
 
 using NTPTilesVector = std::vector<NTPTile>;
 
 }  // namespace ntp_tiles
 
 #endif  // COMPONENTS_NTP_TILES_NTP_TILE_H_