Add support for components/ntp_tiles in InstantService

chrome/browser/resources/local_ntp/most_visited_single.js

 /* Copyright 2015 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file. */
 
  // Single iframe for NTP tiles.
 (function() {
 'use strict';
 
 
 /**
@@ skipping 284 matching lines @@
  */
 var addTile = function(args) {
   if (isFinite(args.rid)) {
     // If a valid number passed in |args.rid|: a local chrome suggestion.
     var data =
         chrome.embeddedSearch.newTabPage.getMostVisitedItemData(args.rid);
     if (!data)
       return;
 
     data.tid = data.rid;
-    data.tileSource = NTPLoggingTileSource.CLIENT;
+    data.tileSource = data.isServerSide ?

[sfiera, 2016/11/29 10:24:03]

isServerSide is added by this CL, right? Can we just set the int from the
beginning?

[Marc Treib, 2016/11/29 15:20:13]

Yes, it's added by this CL. What do you mean by setting the int from the
beginning?

[sfiera, 2016/11/29 15:27:46]

I mean, you start with an enum in InstantService, which you map to a bool, which
you map back to the enum for logging. It would be simpler to set data.tileSource
at the beginning, instead of mapping it through data.isServerSide, wouldn't it?

The NTPLoggingTileSource enum values are equal to the corresponding ntp_tiles::
ones, right? So you don't even need a mapping.

[Marc Treib, 2016/12/01 14:49:40]

Ah, now I see - yes, that makes a lot of sense. (I was reusing an existing (but
unused) is_server_side_suggestion flag in InstantMostVisitedItem...)
I *really* don't want to rely on the fact that the enum values just so happen to
be equal. IMO the solution is to get rid of NTPLoggingTileSource completely, and
just use the ntp_tiles:: version everywhere. I'll make a separate CL and rebase
this one on top of that.

[Marc Treib, 2016/12/07 14:01:31]

Done.

+        NTPLoggingTileSource.SERVER : NTPLoggingTileSource.CLIENT;
     if (!data.faviconUrl) {
       data.faviconUrl = 'chrome-search://favicon/size/16@' +
           window.devicePixelRatio + 'x/' + data.renderViewId + '/' + data.tid;
     }
     tiles.appendChild(renderTile(data));
   } else if (args.url) {
     // If a URL is passed: a server-side suggestion.
     args.tileSource = NTPLoggingTileSource.SERVER;
     // check sanity of the arguments
     if (/^javascript:/i.test(args.url) ||
@@ skipping 290 matching lines @@
     var html = document.querySelector('html');
     html.dir = 'rtl';
   }
 
   window.addEventListener('message', handlePostMessage);
 };
 
 
 window.addEventListener('DOMContentLoaded', init);
 })();