Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2532053004: Mojo C++ bindings: remove the single-threaded Router. (Closed)

Created:
4 years ago by yzshen1
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: remove the single-threaded Router. BUG=594244 Committed: https://crrev.com/a87f4ac9dd870976bbcaab0f416322a7ea60910a Cr-Commit-Position: refs/heads/master@{#435363}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1281 lines) Patch
M mojo/public/cpp/bindings/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/binding.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/interface_ptr.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.h View 1 4 chunks +5 lines, -112 lines 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.cc View 1 2 chunks +13 lines, -87 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_state.h View 1 chunk +1 line, -173 lines 0 comments Download
D mojo/public/cpp/bindings/lib/router.h View 1 chunk +0 lines, -206 lines 0 comments Download
D mojo/public/cpp/bindings/lib/router.cc View 1 chunk +0 lines, -347 lines 0 comments Download
M mojo/public/cpp/bindings/strong_binding.h View 2 chunks +0 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/bindings_perftest.cc View 3 chunks +0 lines, -54 lines 0 comments Download
D mojo/public/cpp/bindings/tests/router_unittest.cc View 1 chunk +0 lines, -290 lines 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years ago (2016-11-28 22:45:51 UTC) #6
Ken Rockot(use gerrit already)
Woohoo! \o/
4 years ago (2016-11-29 22:44:49 UTC) #9
Ken Rockot(use gerrit already)
On 2016/11/29 at 22:44:49, Ken Rockot wrote: > Woohoo! \o/ Oh.... and LGTM
4 years ago (2016-11-29 22:44:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532053004/20001
4 years ago (2016-11-29 22:45:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-30 00:48:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532053004/20001
4 years ago (2016-11-30 17:53:52 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 19:04:54 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-30 19:08:45 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a87f4ac9dd870976bbcaab0f416322a7ea60910a
Cr-Commit-Position: refs/heads/master@{#435363}

Powered by Google App Engine
This is Rietveld 408576698