Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2532043002: [build] Roll build a3b623a:11a223f (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Roll build a3b623a:11a223f This also ports some build overrides including: https://codereview.chromium.org/2512043002/ BUG=chromium:659726 Committed: https://crrev.com/868abcb08592e5fc1ac0d1a1dcc74fb6d000519f Cr-Commit-Position: refs/heads/master@{#41347}

Patch Set 1 #

Patch Set 2 : [build] Roll build a3b623a:850c473 #

Patch Set 3 : Port overrides #

Patch Set 4 : Only roll to 3929f25df312968 #

Patch Set 5 : format #

Patch Set 6 : Roll to 11a223f35ffd36274037647b239e7cc3cd7e7e3b #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -28 lines) Patch
M .gn View 1 2 3 4 2 chunks +4 lines, -27 lines 0 comments Download
M DEPS View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M build_overrides/build.gni View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
kjellander_chromium
lgtm
4 years ago (2016-11-28 10:22:12 UTC) #7
Michael Achenbach
Now blocked on https://codereview.chromium.org/2450933002/ :(
4 years ago (2016-11-28 10:34:56 UTC) #8
Michael Achenbach
patch 6 fixes the win block (i.e. rolls to an upstream revert).
4 years ago (2016-11-29 11:14:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532043002/100001
4 years ago (2016-11-29 11:15:11 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years ago (2016-11-29 11:16:48 UTC) #20
commit-bot: I haz the power
4 years ago (2016-11-29 11:17:29 UTC) #22
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/868abcb08592e5fc1ac0d1a1dcc74fb6d000519f
Cr-Commit-Position: refs/heads/master@{#41347}

Powered by Google App Engine
This is Rietveld 408576698