Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: chrome/browser/chrome_browser_metrics_service_observer.cc

Issue 253203002: Log operator code histogram on new metric log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@api_move
Patch Set: combine and rename metric name. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_metrics_service_observer.cc
diff --git a/chrome/browser/chrome_browser_metrics_service_observer.cc b/chrome/browser/chrome_browser_metrics_service_observer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..289c23e989be3a2b91ad57aa3d9eb1b5cd2b6ca9
--- /dev/null
+++ b/chrome/browser/chrome_browser_metrics_service_observer.cc
@@ -0,0 +1,39 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chrome_browser_metrics_service_observer.h"
+
+#include "chrome/browser/metrics/metrics_service.h"
+
+#if defined(OS_ANDROID)
+#include "base/metrics/sparse_histogram.h"
+#include "base/strings/string_number_conversions.h"
+#include "net/android/network_library.h"
+#endif
+
+ChromeBrowserMetricsServiceObserver::ChromeBrowserMetricsServiceObserver() {
+ MetricsServiceHelper::AddMetricsServiceObserver(this);
+}
+
+ChromeBrowserMetricsServiceObserver::~ChromeBrowserMetricsServiceObserver() {
+ MetricsServiceHelper::RemoveMetricsServiceObserver(this);
+}
+
+void ChromeBrowserMetricsServiceObserver::OnDidCreateMetricsLog() {
+#if defined(OS_ANDROID)
+ net::NetworkChangeNotifier::ConnectionType type =
+ net::NetworkChangeNotifier::GetConnectionType();
+ unsigned mcc_mnc = 0;
+ if (type == net::NetworkChangeNotifier::CONNECTION_2G ||
+ type == net::NetworkChangeNotifier::CONNECTION_3G ||
+ type == net::NetworkChangeNotifier::CONNECTION_4G) {
+ // Log zero if not perfectly converted.
+ if (!base::StringToUint(
+ net::android::GetTelephonyNetworkOperator(), &mcc_mnc)) {
+ mcc_mnc = 0;
+ }
+ }
+ UMA_HISTOGRAM_SPARSE_SLOWLY("NCN.NetworkOperatorMCCMNC", mcc_mnc);
Ilya Sherman 2014/05/08 03:48:40 Can you share lines 27-37 with the equivalent code
bolian 2014/05/08 06:38:24 Done.
+#endif
+}

Powered by Google App Engine
This is Rietveld 408576698