Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h

Issue 253203002: Log operator code histogram on new metric log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@api_move
Patch Set: create observer in ChromeBrowserMainExtraPartsMetrics::PostBrowserStart() Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_H_ 5 #ifndef CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_H_
6 #define CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_H_ 6 #define CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/scoped_ptr.h"
10 #include "chrome/browser/chrome_browser_main_extra_parts.h" 11 #include "chrome/browser/chrome_browser_main_extra_parts.h"
11 12
12 class ChromeBrowserMainParts; 13 class ChromeBrowserMainParts;
14 class ChromeBrowserMetricsServiceObserver;
13 15
14 namespace chrome { 16 namespace chrome {
15 void AddMetricsExtraParts(ChromeBrowserMainParts* main_parts); 17 void AddMetricsExtraParts(ChromeBrowserMainParts* main_parts);
16 } 18 }
17 19
18 class ChromeBrowserMainExtraPartsMetrics : public ChromeBrowserMainExtraParts { 20 class ChromeBrowserMainExtraPartsMetrics : public ChromeBrowserMainExtraParts {
19 public: 21 public:
20 ChromeBrowserMainExtraPartsMetrics(); 22 ChromeBrowserMainExtraPartsMetrics();
21 virtual ~ChromeBrowserMainExtraPartsMetrics(); 23 virtual ~ChromeBrowserMainExtraPartsMetrics();
22 24
23 // Overridden from ChromeBrowserMainExtraParts: 25 // Overridden from ChromeBrowserMainExtraParts:
24 virtual void PreProfileInit() OVERRIDE; 26 virtual void PreProfileInit() OVERRIDE;
25 virtual void PreBrowserStart() OVERRIDE; 27 virtual void PreBrowserStart() OVERRIDE;
26 virtual void PostBrowserStart() OVERRIDE; 28 virtual void PostBrowserStart() OVERRIDE;
27 29
28 private: 30 private:
31 // Observe and log histograms on new metric logs.
32 scoped_ptr<ChromeBrowserMetricsServiceObserver> metrics_service_observer_;
Lei Zhang 2014/05/08 20:32:15 Android-only?
bolian 2014/05/08 22:17:57 I am trying to reduce the #if artifacts, so that I
33
29 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserMainExtraPartsMetrics); 34 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserMainExtraPartsMetrics);
30 }; 35 };
31 36
32 #endif // CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_H_ 37 #endif // CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698