chrome/browser/metrics/metrics_service_observer.h - Issue 253203002: Log operator code histogram on new metric log

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/metrics/metrics_service_observer.h

Issue 253203002: Log operator code histogram on new metric log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@api_move

Patch Set: addressed more comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_METRICS_METRICS_SERVICE_OBSERVER_H_

	6 #define CHROME_BROWSER_METRICS_METRICS_SERVICE_OBSERVER_H_

	7

	8 #include "base/macros.h"

	9

	10 class MetricsServiceObserver {
	Alexei Svitkine (slow) 2014/05/07 17:05:41 Add a comment explaining what this is for. Add a comment explaining what this is for. bolian 2014/05/07 18:11:44 Done. Show quoted text On 2014/05/07 17:05:41, Alexei Svitkine wrote: > Add a comment explaining what this is for. Done.
	11 public:

	12 // Will be called when a new MetricsLog is created.
	bengr 2014/05/07 16:03:58 Will be called -> Called Will be called -> Called bolian 2014/05/07 18:11:44 Done. Show quoted text On 2014/05/07 16:03:58, bengr1 wrote: > Will be called -> Called Done.
	13 virtual void OnDidCreateMetricsLog() = 0;

	14

	15 protected:

	16 MetricsServiceObserver() {}

	17 virtual ~MetricsServiceObserver() {}

	18

	19 private:

	20 DISALLOW_COPY_AND_ASSIGN(MetricsServiceObserver);

	21 };

	22

	23 #endif // CHROME_BROWSER_METRICS_METRICS_SERVICE_OBSERVER_H_

OLD	NEW