chrome/browser/chrome_browser_metrics_service_observer.h - Issue 253203002: Log operator code histogram on new metric log

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chrome_browser_metrics_service_observer.h

Issue 253203002: Log operator code histogram on new metric log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@api_move

Patch Set: addressed more comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_CHROME_BROWSER_METRICS_SERVICE_OBSERVER_H_

	6 #define CHROME_BROWSER_CHROME_BROWSER_METRICS_SERVICE_OBSERVER_H_

	7

	8 #include "chrome/browser/metrics/metrics_service_observer.h"

	9

	10 class ChromeBrowserMetricsServiceObserver: public MetricsServiceObserver {
	Alexei Svitkine (slow) 2014/05/07 17:05:41 Nit: Space before : Also, add a short description Nit: Space before : Also, add a short description of this class. bolian 2014/05/07 18:11:44 Done. Show quoted text On 2014/05/07 17:05:41, Alexei Svitkine wrote: > Nit: Space before : > > Also, add a short description of this class. Done.
	11 public:

	12 ChromeBrowserMetricsServiceObserver();

	13 virtual ~ChromeBrowserMetricsServiceObserver();

	14

	15 // MetricsServiceObserver;
	Alexei Svitkine (slow) 2014/05/07 17:05:41 Nit: ";" -> ":" Nit: ";" -> ":" bolian 2014/05/07 18:11:44 . ? . ? Ilya Sherman 2014/05/07 23:57:40 Shrug. The typical style is to use a colon. Show quoted text On 2014/05/07 18:11:44, bolian wrote: > . ? Shrug. The typical style is to use a colon. bolian 2014/05/08 00:54:51 Done. Show quoted text On 2014/05/07 23:57:40, Ilya Sherman wrote: > On 2014/05/07 18:11:44, bolian wrote: > > . ? > > Shrug. The typical style is to use a colon. Done.
	16 virtual void OnDidCreateMetricsLog() OVERRIDE;

	17

	18 private:

	19 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserMetricsServiceObserver);

	20 };

	21

	22 #endif // CHROME_BROWSER_CHROME_BROWSER_METRICS_SERVICE_OBSERVER_H_

OLD	NEW