Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2532013002: [SUSPENDED] Scheduler: Add deprecation comments on ExecutionContext::postTask() (Closed)

Created:
4 years ago by nhiroki
Modified:
3 years, 6 months ago
Reviewers:
haraken, tzik
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Scheduler: Add deprecation comments on ExecutionContext::postTask() ExecutionContext::postTask() is deprecated. Instead, we should use TaskRunnerHelper or ParentFrameTaskRunners. BUG=624696

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +7 lines, -6 lines 2 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
nhiroki
PTAL
4 years ago (2016-11-28 06:33:44 UTC) #4
haraken
LGTM
4 years ago (2016-11-28 06:35:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532013002/20001
4 years ago (2016-11-28 06:37:16 UTC) #7
tzik
https://codereview.chromium.org/2532013002/diff/20001/third_party/WebKit/Source/core/dom/Document.h File third_party/WebKit/Source/core/dom/Document.h (right): https://codereview.chromium.org/2532013002/diff/20001/third_party/WebKit/Source/core/dom/Document.h#newcode995 third_party/WebKit/Source/core/dom/Document.h:995: // Executes the task on context's thread asynchronously. There ...
4 years ago (2016-11-28 07:27:53 UTC) #8
nhiroki
4 years ago (2016-11-28 08:07:09 UTC) #10 
https://codereview.chromium.org/2532013002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.h (right):

https://codereview.chromium.org/2532013002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.h:995: // Executes the task on
context's thread asynchronously.
On 2016/11/28 07:27:53, tzik wrote:
> There are several missing feature that TaskRunnerHelper doesn't have:
> suspension, cancellation and the inspector instrumentation.
> So, IMO, it's too early to deprecated this.

Thank you for letting me know it. Then, I'll wait until these features are
landed. Are there any crbugs to track them?

Powered by Google App Engine
This is Rietveld 408576698