Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: ui/file_manager/file_manager/foreground/elements/files_metadata_box.js

Issue 2532003005: Quick View: show device model metadata. (Closed)
Patch Set: Addressed comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/elements/files_metadata_box.js
diff --git a/ui/file_manager/file_manager/foreground/elements/files_metadata_box.js b/ui/file_manager/file_manager/foreground/elements/files_metadata_box.js
index a6eb126d6dba68b89941319d93ca88f271f4df51..8428ffdf542afc0081dd4207efd32ea4a15b9834 100644
--- a/ui/file_manager/file_manager/foreground/elements/files_metadata_box.js
+++ b/ui/file_manager/file_manager/foreground/elements/files_metadata_box.js
@@ -46,6 +46,15 @@ var FilesMetadataBox = Polymer({
type: Number,
observer: 'metadataUpdated_',
},
+ /**
+ * Exif information parsed by exif_parser.js or null if there is no
+ * information.
+ * @type {?Object}
+ */
+ ifd: {
+ type: Object,
+ observer: 'metadataUpdated_',
+ },
// Whether the size is the middle of loading.
isSizeLoading: Boolean,
@@ -72,6 +81,7 @@ var FilesMetadataBox = Polymer({
this.mediaDuration = 0;
this.mediaGenre = '';
this.mediaTrack = 0;
+ this.ifd = null;
this.isSizeLoading = false;
},
@@ -108,7 +118,8 @@ var FilesMetadataBox = Polymer({
this.hasFileSpecificInfo_ =
!!(this.imageWidth && this.imageHeight || this.mediaTitle ||
this.mediaArtist || this.mediaAlbum || this.mediaDuration ||
- this.mediaGenre || this.mediaTrack);
+ this.mediaGenre || this.mediaTrack ||
+ this.ifd);
},
/**
@@ -143,4 +154,15 @@ var FilesMetadataBox = Polymer({
return '';
},
+ /**
+ * @param {?Object} ifd
+ * @return {string}
+ *
+ * @private
+ */
+ deviceModel_: function(ifd) {
+ var id = 272;
+ return (ifd && ifd.image && ifd.image[id] && ifd.image[id].value) || '';
+ },
+
});

Powered by Google App Engine
This is Rietveld 408576698