Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: third_party/WebKit/Source/platform/heap/Visitor.cpp

Issue 2531973002: Simple BlinkGC heap compaction. (Closed)
Patch Set: add pointer alignment handling to SparseHeapBitmap Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/heap/Visitor.h" 5 #include "platform/heap/Visitor.h"
6 6
7 #include "platform/heap/BlinkGC.h" 7 #include "platform/heap/BlinkGC.h"
8 #include "platform/heap/MarkingVisitor.h" 8 #include "platform/heap/MarkingVisitor.h"
9 #include "platform/heap/ThreadState.h" 9 #include "platform/heap/ThreadState.h"
10 #include "wtf/PtrUtil.h" 10 #include "wtf/PtrUtil.h"
11 #include <memory> 11 #include <memory>
12 12
13 namespace blink { 13 namespace blink {
14 14
15 std::unique_ptr<Visitor> Visitor::create(ThreadState* state, 15 std::unique_ptr<Visitor> Visitor::create(ThreadState* state,
16 BlinkGC::GCType gcType) { 16 BlinkGC::GCType gcType) {
17 switch (gcType) { 17 switch (gcType) {
18 case BlinkGC::GCWithSweep: 18 case BlinkGC::GCWithSweep:
19 case BlinkGC::GCWithoutSweep: 19 case BlinkGC::GCWithoutSweep:
20 return makeUnique<MarkingVisitor<Visitor::GlobalMarking>>(state); 20 return makeUnique<MarkingVisitor<Visitor::GlobalMarking>>(state);
21 case BlinkGC::GCWithSweepCompaction:
22 return makeUnique<MarkingVisitor<Visitor::GlobalMarkCompacting>>(state);
21 case BlinkGC::TakeSnapshot: 23 case BlinkGC::TakeSnapshot:
22 return makeUnique<MarkingVisitor<Visitor::SnapshotMarking>>(state); 24 return makeUnique<MarkingVisitor<Visitor::SnapshotMarking>>(state);
23 case BlinkGC::ThreadTerminationGC: 25 case BlinkGC::ThreadTerminationGC:
24 return makeUnique<MarkingVisitor<Visitor::ThreadLocalMarking>>(state); 26 return makeUnique<MarkingVisitor<Visitor::ThreadLocalMarking>>(state);
25 case BlinkGC::ThreadLocalWeakProcessing: 27 case BlinkGC::ThreadLocalWeakProcessing:
26 return makeUnique<MarkingVisitor<Visitor::WeakProcessing>>(state); 28 return makeUnique<MarkingVisitor<Visitor::WeakProcessing>>(state);
27 default: 29 default:
28 ASSERT_NOT_REACHED(); 30 ASSERT_NOT_REACHED();
29 } 31 }
30 return nullptr; 32 return nullptr;
31 } 33 }
32 34
33 Visitor::Visitor(ThreadState* state, MarkingMode markingMode) 35 Visitor::Visitor(ThreadState* state, MarkingMode markingMode)
34 : VisitorHelper(state), m_markingMode(markingMode) { 36 : VisitorHelper(state), m_markingMode(markingMode) {
35 // See ThreadState::runScheduledGC() why we need to already be in a 37 // See ThreadState::runScheduledGC() why we need to already be in a
36 // GCForbiddenScope before any safe point is entered. 38 // GCForbiddenScope before any safe point is entered.
37 state->enterGCForbiddenScope(); 39 DCHECK(state->isGCForbidden());
38 40 #if ENABLE(ASSERT)
39 ASSERT(state->checkThread()); 41 DCHECK(state->checkThread());
42 #endif
40 } 43 }
41 44
42 Visitor::~Visitor() { 45 Visitor::~Visitor() {}
43 state()->leaveGCForbiddenScope();
44 }
45 46
46 } // namespace blink 47 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698