gfx: Fix sending native ozone pixmaps from InProcessCommandBuffer.

gpu/ipc/client/command_buffer_proxy_impl.cc

Index: gpu/ipc/client/command_buffer_proxy_impl.cc
diff --git a/gpu/ipc/client/command_buffer_proxy_impl.cc b/gpu/ipc/client/command_buffer_proxy_impl.cc
index 00040507432abe97255f601f4ddec58ec1043325..021023a96844f8e771e71d32da47e18463fb5a78 100644
--- a/gpu/ipc/client/command_buffer_proxy_impl.cc
+++ b/gpu/ipc/client/command_buffer_proxy_impl.cc
@@ -462,10 +462,11 @@ int32_t CommandBufferProxyImpl::CreateImage(ClientBuffer buffer,
   // This handle is owned by the GPU process and must be passed to it or it
   // will leak. In otherwords, do not early out on error between here and the
   // sending of the CreateImage IPC below.
-  bool requires_sync_token = false;
   gfx::GpuMemoryBufferHandle handle =
-      channel_->ShareGpuMemoryBufferToGpuProcess(gpu_memory_buffer->GetHandle(),
-                                                 &requires_sync_token);
+      channel_->IsLost()

[piman, 2016/11/28 23:42:36]

Actually this is not necessary anymore, since now handle ownership is passed to
the IPC system on all platforms (including Windows and Mac). This check is racy
anyway (IsLost can change on the IO thread)... previously the code was
duplicating handles directly into the GPU process, and there could be ways in
which they were leaked there if we couldn't send the message. But now the handle
is always passed/brokered/freed whether the message is sent or not, so I think
we should just unconditionally clone. If the channel is lost, we're most likely
going to early out on l.451, the only few remaining cases (channel is lost on
the IO thread but we haven't yet executed the task that tells us so) are not
interesting to "optimize".

[sadrul, 2016/11/29 01:53:51]

Oh cool. Thanks! Removed the IsLost() check from here.

+          ? gfx::GpuMemoryBufferHandle()
+          : gfx::CloneHandleForIPC(gpu_memory_buffer->GetHandle());

[sadrul, 2016/11/27 03:59:06]

This may actually change behaviour. Right now, 'IsLost()' is checked only when
the GMBHandle's type is SHARED_MEMORY_HANDLE, and only the SharedMemoryHandle is
null'ed out. The rest of the fields are copied/cloned normally. With this
change, all of the fields are left invalid. I think this ought to be OK?

+  bool requires_sync_token = handle.type == gfx::IO_SURFACE_BUFFER;
 
   uint64_t image_fence_sync = 0;
   if (requires_sync_token) {