Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25319002: quiet down more third-party warnings (Closed)

Created:
7 years, 2 months ago by mtklein
Modified:
7 years, 2 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

quiet down more third-party warnings in poppler and jsoncpp BUG= Committed: http://code.google.com/p/skia/source/detail?r=11530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M gyp/jsoncpp.gyp View 1 chunk +2 lines, -6 lines 0 comments Download
M gyp/poppler.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
7 years, 2 months ago (2013-09-30 18:03:47 UTC) #1
djsollen
lgtm
7 years, 2 months ago (2013-09-30 18:06:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/25319002/1
7 years, 2 months ago (2013-09-30 18:07:39 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-09-30 18:19:29 UTC) #4
Message was sent while issue was closed. 
Change committed as 11530

Powered by Google App Engine
This is Rietveld 408576698