Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2531873003: [heap] Use safe way to obtain page in PagedSpace::Contains(Address addr). (Closed)

Created:
4 years ago by Hannes Payer (out of office)
Modified:
4 years ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Use safe way to obtain page in PagedSpace::Contains(Address addr). Committed: https://crrev.com/2d3d66ab6410dd79eb9653301314abf271a174de Cr-Commit-Position: refs/heads/master@{#41290}

Patch Set 1 #

Patch Set 2 : [heap] Use safe way to obtain page in PagedSpace::Contains(Address addr). #

Patch Set 3 : use heap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/heap/spaces-inl.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Michael Lippautz
lgtm, thanks for explaining offline
4 years ago (2016-11-25 16:40:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531873003/40001
4 years ago (2016-11-25 17:04:05 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-25 17:08:05 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-25 17:08:23 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2d3d66ab6410dd79eb9653301314abf271a174de
Cr-Commit-Position: refs/heads/master@{#41290}

Powered by Google App Engine
This is Rietveld 408576698