|
|
Created:
4 years ago by Hannes Payer (out of office) Modified:
4 years ago Reviewers:
Michael Lippautz CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Use safe way to obtain page in PagedSpace::Contains(Address addr).
Committed: https://crrev.com/2d3d66ab6410dd79eb9653301314abf271a174de
Cr-Commit-Position: refs/heads/master@{#41290}
Patch Set 1 #Patch Set 2 : [heap] Use safe way to obtain page in PagedSpace::Contains(Address addr). #Patch Set 3 : use heap #
Created: 4 years ago
Messages
Total messages: 16 (12 generated)
The CQ bit was checked by hpayer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/16879) v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/16930) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/18564)
The CQ bit was checked by hpayer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mlippautz@chromium.org changed reviewers: + mlippautz@chromium.org
lgtm, thanks for explaining offline
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hpayer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480093442640530, "parent_rev": "4bd4c68e3d47074c35bf74fb600e8291c35d36e3", "commit_rev": "e4d20be4e4e25d4d47f08ef445a933262f3af7d3"}
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Use safe way to obtain page in PagedSpace::Contains(Address addr). ========== to ========== [heap] Use safe way to obtain page in PagedSpace::Contains(Address addr). Committed: https://crrev.com/2d3d66ab6410dd79eb9653301314abf271a174de Cr-Commit-Position: refs/heads/master@{#41290} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2d3d66ab6410dd79eb9653301314abf271a174de Cr-Commit-Position: refs/heads/master@{#41290} |