Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: pkg/kernel/test/baseline_tester.dart

Issue 2531873002: Add --verify-ir flag to dartk and test.py. (Closed)
Patch Set: Minor fixes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/kernel/lib/verifier.dart ('k') | pkg/kernel/test/check_bench.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 import 'dart:io'; 4 import 'dart:io';
5 5
6 import 'package:kernel/analyzer/loader.dart'; 6 import 'package:kernel/analyzer/loader.dart';
7 import 'package:kernel/kernel.dart'; 7 import 'package:kernel/kernel.dart';
8 import 'package:kernel/target/targets.dart'; 8 import 'package:kernel/target/targets.dart';
9 import 'package:kernel/text/ast_to_text.dart'; 9 import 'package:kernel/text/ast_to_text.dart';
10 import 'package:kernel/verifier.dart';
10 import 'package:path/path.dart' as pathlib; 11 import 'package:path/path.dart' as pathlib;
11 import 'package:test/test.dart'; 12 import 'package:test/test.dart';
12 import 'package:kernel/checks.dart';
13 13
14 final String testcaseDirectory = 'pkg/kernel/testcases'; 14 final String testcaseDirectory = 'pkg/kernel/testcases';
15 final String inputDirectory = 'pkg/kernel/testcases/input'; 15 final String inputDirectory = 'pkg/kernel/testcases/input';
16 final String sdkDirectory = 'sdk'; 16 final String sdkDirectory = 'sdk';
17 17
18 /// A target to be used for testing. 18 /// A target to be used for testing.
19 /// 19 ///
20 /// To simplify testing dependencies, we avoid transformations that rely on 20 /// To simplify testing dependencies, we avoid transformations that rely on
21 /// a patched SDK or any SDK changes that have not landed in the main SDK. 21 /// a patched SDK or any SDK changes that have not landed in the main SDK.
22 abstract class TestTarget extends Target { 22 abstract class TestTarget extends Target {
(...skipping 17 matching lines...) Expand all
40 String filenameOfCurrent = '$outputDirectory/$shortName.current.txt'; 40 String filenameOfCurrent = '$outputDirectory/$shortName.current.txt';
41 41
42 var repository = new Repository(); 42 var repository = new Repository();
43 var loader = await batch.getLoader( 43 var loader = await batch.getLoader(
44 repository, 44 repository,
45 new DartOptions( 45 new DartOptions(
46 strongMode: target.strongMode, 46 strongMode: target.strongMode,
47 sdk: sdkDirectory, 47 sdk: sdkDirectory,
48 declaredVariables: target.extraDeclaredVariables)); 48 declaredVariables: target.extraDeclaredVariables));
49 var program = loader.loadProgram(dartPath, target: target); 49 var program = loader.loadProgram(dartPath, target: target);
50 runSanityChecks(program); 50 verifyProgram(program);
51 var errors = target.transformProgram(program); 51 var errors = target.transformProgram(program);
52 runSanityChecks(program); 52 verifyProgram(program);
53 53
54 var buffer = new StringBuffer(); 54 var buffer = new StringBuffer();
55 for (var error in errors) { 55 for (var error in errors) {
56 buffer.writeln('// $error'); 56 buffer.writeln('// $error');
57 } 57 }
58 new Printer(buffer, annotator: target.annotator) 58 new Printer(buffer, annotator: target.annotator)
59 .writeLibraryFile(program.mainMethod.enclosingLibrary); 59 .writeLibraryFile(program.mainMethod.enclosingLibrary);
60 String current = '$buffer'; 60 String current = '$buffer';
61 new File(filenameOfCurrent).writeAsStringSync(current); 61 new File(filenameOfCurrent).writeAsStringSync(current);
62 62
63 var baselineFile = new File(filenameOfBaseline); 63 var baselineFile = new File(filenameOfBaseline);
64 if (!baselineFile.existsSync()) { 64 if (!baselineFile.existsSync()) {
65 new File(filenameOfBaseline).writeAsStringSync(current); 65 new File(filenameOfBaseline).writeAsStringSync(current);
66 } else { 66 } else {
67 var baseline = baselineFile.readAsStringSync(); 67 var baseline = baselineFile.readAsStringSync();
68 if (baseline != current) { 68 if (baseline != current) {
69 fail('Output of `$name` changed for $folderName.\n' 69 fail('Output of `$name` changed for $folderName.\n'
70 'Command to reset the baseline:\n' 70 'Command to reset the baseline:\n'
71 ' rm $filenameOfBaseline\n' 71 ' rm $filenameOfBaseline\n'
72 'Command to see the diff:\n' 72 'Command to see the diff:\n'
73 ' diff -cd $outputDirectory/$shortName.{baseline,current}.txt' 73 ' diff -cd $outputDirectory/$shortName.{baseline,current}.txt'
74 '\n'); 74 '\n');
75 } 75 }
76 } 76 }
77 }); 77 });
78 } 78 }
79 } 79 }
80 } 80 }
OLDNEW
« no previous file with comments | « pkg/kernel/lib/verifier.dart ('k') | pkg/kernel/test/check_bench.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698