Update AD status on chrome://policy page automatically

Update AD status on chrome://policy page automatically

Make DeviceActiveDirectoryPolicyStatusProvider observe CloudPolicyStore.

BUG=668652
Committed: https://crrev.com/663a3d2f6e017ebcc9c679ea436dcde11234e921
Cr-Commit-Position: refs/heads/master@{#434661}

[Thiemo Nagel, 2016-11-25 11:08:36]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 11:08:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 11:53:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 11:53:04]

Dry run: This issue passed the CQ dry run.

[Thiemo Nagel, 2016-11-25 13:52:02]

tnagel@chromium.org changed reviewers:
+ bauerb@chromium.org

[Thiemo Nagel, 2016-11-25 13:52:03]

Hi Bernhard,

may I kindly ask you to take a look?

Thank you,
Thiemo

[Bernhard Bauer, 2016-11-25 15:17:20]

lgtm

https://codereview.chromium.org/2531793002/diff/1/chrome/browser/chromeos/pol...
File chrome/browser/chromeos/policy/device_active_directory_policy_manager.h
(right):

https://codereview.chromium.org/2531793002/diff/1/chrome/browser/chromeos/pol...
chrome/browser/chromeos/policy/device_active_directory_policy_manager.h:37:
const CloudPolicyStore* store() const { return store_.get(); }
Do you use this anywhere else? Otherwise I'd just make this return a mutable
CloudPolicyStore*. TBH, having these two methods feels a bit like overkill, but
your call, really.

[Thiemo Nagel, 2016-11-28 14:49:40]

Thank you!

https://codereview.chromium.org/2531793002/diff/1/chrome/browser/chromeos/pol...
File chrome/browser/chromeos/policy/device_active_directory_policy_manager.h
(right):

https://codereview.chromium.org/2531793002/diff/1/chrome/browser/chromeos/pol...
chrome/browser/chromeos/policy/device_active_directory_policy_manager.h:37:
const CloudPolicyStore* store() const { return store_.get(); }
On 2016/11/25 15:17:20, Bernhard Bauer wrote:
> Do you use this anywhere else? Otherwise I'd just make this return a mutable
> CloudPolicyStore*. TBH, having these two methods feels a bit like overkill,
but
> your call, really.

Imho it would be better style to separate mutable and immutable accessors, but
it doesn't seem to be common in the codebase, thus I probably should prioritize
consistency...

[Thiemo Nagel, 2016-11-28 14:49:58]

The CQ bit was checked by tnagel@chromium.org

[Thiemo Nagel, 2016-11-28 14:49:58]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2531793002/#ps20001
(title: "Address Bernhard's comment.")

[commit-bot: I haz the power, 2016-11-28 14:50:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 15:02:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 15:02:41]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Thiemo Nagel, 2016-11-28 15:13:41]

The CQ bit was checked by tnagel@chromium.org

[Thiemo Nagel, 2016-11-28 15:13:42]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2531793002/#ps40001
(title: "Fix compilation")

[commit-bot: I haz the power, 2016-11-28 15:13:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 16:06:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480346021474240,
"parent_rev": "d95bb2062440650c03b206e5891f67ead3dc1c71", "commit_rev":
"8168828d87610e996feede6120a9f213b3c3e39d"}

[commit-bot: I haz the power, 2016-11-28 16:07:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-28 16:08:39]

Description was changed from

==========
Update AD status on chrome://policy page automatically

Make DeviceActiveDirectoryPolicyStatusProvider observe CloudPolicyStore.

BUG=668652
==========

to

==========
Update AD status on chrome://policy page automatically

Make DeviceActiveDirectoryPolicyStatusProvider observe CloudPolicyStore.

BUG=668652

Committed: https://crrev.com/663a3d2f6e017ebcc9c679ea436dcde11234e921
Cr-Commit-Position: refs/heads/master@{#434661}
==========

[commit-bot: I haz the power, 2016-11-28 16:08:40]

Patchset 3 (id:??) landed as
https://crrev.com/663a3d2f6e017ebcc9c679ea436dcde11234e921
Cr-Commit-Position: refs/heads/master@{#434661}