Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2531753002: CSS Independent Transform Properties: support rotate: <axes> <angle> (Closed)
Patch Set: tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
index cb27b6b55f89c8eb1707cfce2d21562dcd142272..1b7bfb4d1f4887d1c40acf5dfef7b605c59800eb 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
@@ -731,21 +731,21 @@ static CSSValueList* consumeRotation(CSSParserTokenRange& range) {
ASSERT(RuntimeEnabledFeatures::cssIndependentTransformPropertiesEnabled());
CSSValueList* list = CSSValueList::createSpaceSeparated();
- CSSValue* rotation = consumeAngle(range);
- if (!rotation)
- return nullptr;
- list->append(*rotation);
-
- if (range.atEnd())
- return list;
-
for (unsigned i = 0; i < 3; i++) { // 3 dimensions of rotation
CSSValue* dimension = consumeNumber(range, ValueRangeAll);
- if (!dimension)
+ if (!dimension) {
+ if (i == 0)
+ break;
return nullptr;
+ }
list->append(*dimension);
}
+ CSSValue* rotation = consumeAngle(range);
+ if (!rotation)
+ return nullptr;
+ list->append(*rotation);
+
return list;
}

Powered by Google App Engine
This is Rietveld 408576698